Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (nike.apache.org: domain of
 SRS0=tlTk=D7=m4x.org=sebastien.brisard@bounces.m4x.org designates
 129.104.30.34 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <4FC2507E.6010303@free.fr>
References: 
 <CAGRH7Hqk2VUSHGdTx0NxDgFg9hnXZ9FRBHJoDvP+z2FYsqr4MQ@mail.gmail.com>
	<4FBE8EED.5080107@free.fr>
	<CAF8HOZJ=Xh6U5owDz2fwRGYbSU7x8oLr1xJRoyNKJXK=D+xtGw@mail.gmail.com>
	<4FC2507E.6010303@free.fr>
Date: Sun, 27 May 2012 21:21:13 +0200
Message-ID: 
 <CAGRH7HpYsv6PO8=BSbrYnMA0hVXgmwdV8aQ0hcv3BpqGZqcsqw@mail.gmail.com>
Subject: Re: [math] LocalizedFormats.ALPHA and BETA no longer used
From: =?ISO-8859-1?Q?S=E9bastien_Brisard?= <sebastien.brisard@m4x.org>
To: Commons Developers List <dev@commons.apache.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Hi,

2012/5/27 Luc Maisonobe <Luc.Maisonobe@free.fr>:
> Le 27/05/2012 16:25, Jochen Wiedmann a =E9crit :
>> On Thu, May 24, 2012 at 8:41 PM, Luc Maisonobe <Luc.Maisonobe@free.fr> w=
rote:
>>> Le 24/05/2012 21:27, S=E9bastien Brisard a =E9crit :
>>>> Hi,
>>>> commit 1342404 solves MATH-791. It turns out that
>>>> LocalizedFormats.ALPHA and BETA are no longer used. I wanted to remove
>>>> them, but that breaks the compatibility. How should we do that
>>>> cleanly?
>>>
>>> Just remove the entries from the enum and temove the corresponding entr=
y
>>> in the translation properties file.
>>
>> Why remove them at all? I understand the desire, it meets my sense for
>> clean code. But I learned to fight against these desires from time to
>> time.
>
> These parameters are mainly for internal use, we don't consider them as
> part of the public API. As we remove their internal use, it seems good
> to be consistent and remove everything at once.
>
I fully agree.

>
> Do you have an idea about another use that could justify we retain them ?
>
It's probably just as well to restore these constants if we find a use
for them at a later point (that would be trivial).

So, do we agree that these constants should go? How should I proceed?
The clean way (deprecation in 3.1, and complete removal in 4.0), or
the brutal way (complete removal in 3.1) ?

Best regards,
S=E9bastien


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org