Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: neutral (nike.apache.org: local policy)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=yahoo.com.br;
  h=X-YMail-OSG:Received:X-Mailer:References:Message-ID:Date:From:Reply-To:Subject:To:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding;
  b=IvEx1w4Xg840Og5DUpahsAnBA2WH8X/9PDtb7+lM2sjahBskJGxEahhDyi2cndZ0KTf44G7DNM+iZVaNiOI92+h7Y8wer2biRbJgxlKCsvdLWu2YdaAaQnph6B4YzVzemxS/kxuec+6DmjsXGvSpa6tkOH/BY8LmtbVNJn5ne3Y=;
References: <1336674453.81058.YahooMailNeo@web161202.mail.bf1.yahoo.com>
 <CAE9L6G1F3AyDZ=8cLBXFRGt=NmBFSMMeosKp2zhZR=RdUn_AaA@mail.gmail.com>
Message-ID: <1336676940.74287.YahooMailNeo@web161205.mail.bf1.yahoo.com>
Date: Thu, 10 May 2012 12:09:00 -0700 (PDT)
From: "Bruno P. Kinoshita" <brunodepaulak@yahoo.com.br>
Reply-To: "Bruno P. Kinoshita" <brunodepaulak@yahoo.com.br>
Subject: Re: [functor] Remove duplicated equals() methods
To: Commons Developers List <dev@commons.apache.org>,
  "gudnabrsam@gmail.com" <gudnabrsam@gmail.com>
In-Reply-To: 
 <CAE9L6G1F3AyDZ=8cLBXFRGt=NmBFSMMeosKp2zhZR=RdUn_AaA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable

On 05/10/2012 03:38 PM, Matt Benson wrote:=0A> On Thu, May 10, 2012 at 1:27=
 PM, Bruno P. Kinoshita=0A> <brunodepaulak@yahoo.com.br> =A0wrote:=0A>> Hi =
all,=0A>>=0A>> While I am still trying to find time to work on a proposal f=
or enhancements in the generators API in [functor] (https://issues.apache.o=
rg/jira/browse/FUNCTOR-14), I'm reviewing other pending issues, including t=
he one regarding test coverage.=0A>>=0A>> The comparators API seemed to be =
lacking tests for some decision branches. But looking closely at the code, =
I realized that there were two equals code in some comparator functors. The=
n I set up a Sonar instance to scan the code, and found that it is common i=
n many other parts of the code (http://66.228.56.222/sonar/drilldown/violat=
ions/org.apache.commons:commons-functor?severity=3DCRITICAL).=0A>>=0A>> Doe=
s anybody know if there is some reason for having both equals(Object that) =
and equals(SomeFunctor<?> =A0that)? I think we could merge both methods in =
only one. The Generators in [functor] have only one equals() method, and co=
mpares against this, uses instanceof, etc. I had a quick look on [math3] an=
d [lang3], and looks like they both use only one equals() method, compares =
against this, uses instaceof, etc.=0A>>=0A>> If there is no objection here,=
 I could create a patch for this in Jira, merging both equals() methods in =
one :-) Then after this I will proceed writing tests to increase the test c=
overage (https://issues.apache.org/jira/browse/FUNCTOR-12).=0A>>=0A>=A0=0A>=
 Bruno,=0A> =A0 =A0As far as I know this pattern was introduced by one of [=
functor]'s=0A> original authors and must simply have been his preference. =
=A0Personally=0A> I agree that this is not what your average Java developer=
 probably=0A> expects to see in your average Java codebase, and would suppo=
rt=0A> combining these methods. =A0This is documented at [1] and filed at [=
2]=0A> (where your earlier comment is valid, and is also mentioned at [1],=
=0A> but doesn't IMHO pertain specifically to this JIRA issue).=0A>=A0=0A> =
Regards,=0A> Matt=0A>=A0=0A> [1] http://wiki.apache.org/commons/Sanity%20Ch=
eck%20of%20APIs%2C%20etc.=0A> [2] https://issues.apache.org/jira/browse/FUN=
CTOR-11=0A>=A0=0A>> Thanks in advance!=0A>>=0A>> Bruno P. Kinoshita=0A>> ht=
tp://kinoshita.eti.br=0A>> http://tupilabs.com=0A>>=0A>> ------------------=
---------------------------------------------------=0A>> To unsubscribe, e-=
mail: dev-unsubscribe@commons.apache.org=0A>> For additional commands, e-ma=
il: dev-help@commons.apache.org=0A>>=0A=0AHi Matt,=0A=0AThanks for your spe=
edy reply and for sending me the links.=0A=0AYou are right indeed, there is=
 already an issue filled for this, and my comment is not pertinent to that =
issue :-)=0A=0AThe comment in question refers to the item "- why are equals=
, hashCode and toString defined in the Functor interface?" from [1]. Maybe =
we should create a separate issue for that, WDYT?=0A=0AI will use FUNCTOR-1=
1 to attach my patch combining the equals() methods.=0A=0ARegarding the San=
ity Check Wiki entry, do you think we should add "Remove @author tags" too?=
 I believe it has been decided in Apache Commons to stop using this tag (I =
can't remember if it is only the @author tag, or there are other tags too).=
=0A=0ABTW, I filled another issue=A0[2]=A0today with a patch that fixes som=
e minor checkstyle errors in [functor].=0A=0AThanks again!=0A=0A--=A0=0ABru=
no P. Kinoshita=0Ahttp://www.kinoshita.eti.br=0Ahttp://www.tupilabs.com=0A=
=0A[1] http://wiki.apache.org/commons/Sanity%20Check%20of%20APIs%2C%20etc.=
=0A[2]=A0https://issues.apache.org/jira/browse/FUNCTOR-16=0A

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org