Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: neutral (athena.apache.org: local policy)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=yahoo.com.br;
  h=X-YMail-OSG:Received:X-Mailer:Message-ID:Date:From:Reply-To:Subject:To:MIME-Version:Content-Type:Content-Transfer-Encoding;
  b=eC/EbHOJNG9fm03VzlrvNfrPU4ersVhYKGBksGNFuRsFe6A5SyNgJ1THg3J4F3rTK3BJI0DPYmDUW4m0HLqWmgLx7eYPSC16u3ItLHU3ovPWLDr4KEe1VQZ9YxqPZJ66inYTUj9E5HSWWjzIkzVTQrofH00Cmpn3QUhJsIRZ99U=;
Message-ID: <1336674453.81058.YahooMailNeo@web161202.mail.bf1.yahoo.com>
Date: Thu, 10 May 2012 11:27:33 -0700 (PDT)
From: "Bruno P. Kinoshita" <brunodepaulak@yahoo.com.br>
Reply-To: "Bruno P. Kinoshita" <brunodepaulak@yahoo.com.br>
Subject: [functor] Remove duplicated equals() methods
To: Commons List <dev@commons.apache.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable

Hi all,=A0=0A=0AWhile I am still trying to find time to work on a proposal =
for enhancements in the generators API in [functor] (https://issues.apache.=
org/jira/browse/FUNCTOR-14), I'm reviewing other pending issues, including =
the one regarding test coverage.=A0=0A=0AThe comparators API seemed to be l=
acking tests for some decision branches. But looking closely at the code, I=
 realized that there were two equals code in some comparator functors. Then=
 I set up a Sonar instance to scan the code, and found that it is common in=
 many other parts of the code (http://66.228.56.222/sonar/drilldown/violati=
ons/org.apache.commons:commons-functor?severity=3DCRITICAL).=0A=0ADoes anyb=
ody know if there is some reason for having both equals(Object that) and eq=
uals(SomeFunctor<?> that)? I think we could merge both methods in only one.=
 The Generators in [functor] have only one equals() method, and compares ag=
ainst this, uses instanceof, etc. I had a quick look on [math3] and [lang3]=
, and looks like they both use only one equals() method, compares against t=
his, uses instaceof, etc.=0A=0AIf there is no objection here, I could creat=
e a patch for this in Jira, merging both equals() methods in one :-) Then a=
fter this I will proceed writing tests to increase the test coverage (https=
://issues.apache.org/jira/browse/FUNCTOR-12).=0A=0AThanks in advance!=A0=0A=
=0ABruno P. Kinoshita=0Ahttp://kinoshita.eti.br=0Ahttp://tupilabs.com

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org