commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb AT ASF <s...@apache.org>
Subject Re: svn commit: r1334070 - /commons/proper/pool/trunk/src/main/java/org/apache/commons/pool2/impl/GenericKeyedObjectPool.java
Date Fri, 04 May 2012 17:47:08 GMT
On 4 May 2012 18:26,  <sebb@apache.org> wrote:
> Author: sebb
> Date: Fri May  4 17:26:46 2012
> New Revision: 1334070
>
> URL: http://svn.apache.org/viewvc?rev=1334070&view=rev
> Log:
> Wrong place to check for null; returning prevents any entries from being created

This fixes the first two test failures.

> Modified:
>    commons/proper/pool/trunk/src/main/java/org/apache/commons/pool2/impl/GenericKeyedObjectPool.java
>
> Modified: commons/proper/pool/trunk/src/main/java/org/apache/commons/pool2/impl/GenericKeyedObjectPool.java
> URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/main/java/org/apache/commons/pool2/impl/GenericKeyedObjectPool.java?rev=1334070&r1=1334069&r2=1334070&view=diff
> ==============================================================================
> --- commons/proper/pool/trunk/src/main/java/org/apache/commons/pool2/impl/GenericKeyedObjectPool.java
(original)
> +++ commons/proper/pool/trunk/src/main/java/org/apache/commons/pool2/impl/GenericKeyedObjectPool.java
Fri May  4 17:26:46 2012
> @@ -1094,10 +1094,6 @@ public class GenericKeyedObjectPool<K,T>
>     private void ensureMinIdle(K key) throws Exception {
>         // Calculate current pool objects
>         ObjectDeque<T> objectDeque = poolMap.get(key);
> -        // Protect against NPEs in case the key has been removed
> -        if (objectDeque == null) {
> -            return;
> -        }
>
>         // this method isn't synchronized so the
>         // calculateDeficit is done at the beginning
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message