commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Thomas Neidhart <thomas.neidh...@gmail.com>
Subject Re: [math] Exposing the Lanczos approximation in o.a.c.m3.special.Gamma?
Date Wed, 09 May 2012 08:05:34 GMT
On Wed, May 9, 2012 at 7:40 AM, S├ębastien Brisard <sebastien.brisard@m4x.org
> wrote:

> Hi,
> the patch for the proposed modification has been attached to the
> MATH-753 ticket. Thanks for your comments!
>

What I have seen in the patch, you remove duplicated code by using the
already existing lanczos function, and create an additional function for
the constant.
I guess just creating a public final static constant for the LANCZOS_G
value would be better?

Thomas

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message