commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Luc Maisonobe <Luc.Maison...@free.fr>
Subject Re: svn commit: r1343293 - /commons/proper/math/trunk/src/main/java/org/apache/commons/math3/linear/RealVector.java
Date Tue, 29 May 2012 09:09:02 GMT
Le 29/05/2012 06:21, Sébastien Brisard a écrit :
> Hello,
>>
>> I don't see why there should be a consensus to remove something that was
>> never there in the first place. The vast majority of such exception
>> instantiations do not perform explicit conversion; so I'd be inclined to
>> think that there should be a consensus to change that.
>>
>>
>> Best regards,
>> Gilles
>>
> while I agree with you, I do not really know what to do: am I to
> ignore this -1 on one of my commits? This goes against the rules.
> In its latest state, the code I've committed uses auto-boxing.

+1 to revert to no explicit conversion in this specific case (i.e. it is
only an exception message, not a result computation, so it is worth
having simple code).

-1 to a general catch all rule, I guess the need for complicated code is
really context dependent.

Luc

> 
> Best regards,
> Sébastien
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
> 
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message