commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject Re: svn commit: r1334103 - /commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/impl/TestGenericKeyedObjectPool.java
Date Sat, 05 May 2012 20:08:18 GMT
On 05/05/2012 11:22, sebb AT ASF wrote:
> On 4 May 2012 19:05, sebb AT ASF <sebb@apache.org> wrote:
>> The following change to the GKOP ctor seems to fix the problem:
>>
>>
>>        if (factory == null) {
>>            this.close(); // <============= close the parent
>>            throw new IllegalArgumentException("factory may not be null");
>>        }
>>
>> Not 100% sure if that is the correct fix - perhaps tearDown() needs to
>> be adjusted?
> 
> I've fixed GOP and GKOP to call jmxUnregister() instead.
> Hope that's OK; it fixes the remaining test errors.

Looks good to me.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message