commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilles Sadowski <gil...@harfang.homelinux.org>
Subject Re: [math] Exposing the Lanczos approximation in o.a.c.m3.special.Gamma?
Date Wed, 09 May 2012 10:38:21 GMT
Hello.

> > the patch for the proposed modification has been attached to the
> > MATH-753 ticket. Thanks for your comments!
> >
> 
> What I have seen in the patch, you remove duplicated code by using the
> already existing lanczos function, and create an additional function for
> the constant.
> I guess just creating a public final static constant for the LANCZOS_G
> value would be better?

+1
[This is truly a "constant", not some arbitrarily chosen default value, which
I'm generally wary to make "public".]


Best,
Gilles

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message