Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (nike.apache.org: domain of
 SRS0=gwVt=CT=m4x.org=sebastien.brisard@bounces.m4x.org designates
 129.104.30.34 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <de1b72683fff6dbfbca289ea3273ab01@spaceroots.org>
References: 
 <CAGRH7HpotnwDbiXZbLHHYm==jqhXHh51dBYHiSXkmKqakmnBbA@mail.gmail.com>
	<de1b72683fff6dbfbca289ea3273ab01@spaceroots.org>
Date: Fri, 13 Apr 2012 17:30:05 +0200
Message-ID: 
 <CAGRH7Hpvxh=MuQBD+Hfav9iBWw08ZV-5f62yMYPhxomd6Yevfw@mail.gmail.com>
Subject: Re: [math] Is overflow dealt with properly in Dfp?
From: =?ISO-8859-1?Q?S=E9bastien_Brisard?= <sebastien.brisard@m4x.org>
To: Commons Developers List <dev@commons.apache.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Hello,
>
>> I'm currently working on MATH-753, and the underlying accuracy issues.
>> I therefore implemented the Gamma function for Dfps, and came accross
>> a few strange things. For example, althoug the javadoc states that the
>> maximum exponent is 32768, there is no systematic check on this limit.
>> I suppose overflow should happen in the following case
>> {code}
>> =A0 =A0DfpField field =3D new DfpField(40);
>> =A0 =A0final Dfp x =3D field.getOne().power10K(Integer.MAX_VALUE);
>> =A0 =A0System.out.println(x);
>> =A0 =A0System.out.println(x.isInfinite());
>> {code}
>>
>> Instead, what happens is
>> {console}
>> 1.000000000000000000000000000000000000e-4
>> false
>> {console}
>>
>> The surprising answer comes from the fact that power10K actually
>> increments its integer argument. I do not think the above printout is
>> the expected behavior, am I wrong? I think this is potentially a vast
>> issue, because a quick check seems to indicate that "this.nans =3D=3D
>> INFINITE" is often checked in class Dfp, but I don't think the
>> statement "this.nans =3D INFINITE" ever occurs, which would mean that
>> overflow is never dealt with properly. Again, I'm probably wrong, I'd
>> like to have the feeling of someone more used to this class than I am.
>
>
> I obviously agree this result is wrong ...
>
> Is William (the creator of both Dfp and FastMath) still around to deal wi=
th
> this issue ?
>
I'm afraid he probably is not... I feel like walking on eggs on this
issue, because I'm not yet fully familiar with the Dfp class. If
everyone agrees, I'll wait a little bit before I file a bug report.
S=E9bastien


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org