Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (nike.apache.org: domain of garydgregory@gmail.com
 designates 209.85.160.43 as permitted sender)
MIME-Version: 1.0
In-Reply-To: 
 <CAOGo0VZS4-2ScZCCbjbaZF9n0tO5U9o7HHeL6P8UmW3X+QZrgg@mail.gmail.com>
References: 
 <CACZkXPzyLtDt6R7CEDpzb9EakU3c0-N8XC1DSgUMq8eo7e9n+Q@mail.gmail.com>
	<jlkeak$591$1@dough.gmane.org>
	<CAOGo0VZS4-2ScZCCbjbaZF9n0tO5U9o7HHeL6P8UmW3X+QZrgg@mail.gmail.com>
Date: Fri, 6 Apr 2012 16:58:05 -0400
Message-ID: 
 <CACZkXPx9RBw1cCCvP-k4pT0=YJr2fEmhxj7wjHunB0BEmpMOUA@mail.gmail.com>
Subject: Re: [lang] SerializationUtils and generics
From: Gary Gregory <garydgregory@gmail.com>
To: Commons Developers List <dev@commons.apache.org>
Content-Type: multipart/alternative; boundary=e89a8ff1c378b6cdec04bd08e9f5

--e89a8ff1c378b6cdec04bd08e9f5
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Fri, Apr 6, 2012 at 12:44 PM, sebb <sebbaz@gmail.com> wrote:

> On 5 April 2012 16:38, J=C3=B6rg Schaible <Joerg.Schaible@scalaris.com> w=
rote:
> > Hi Gary,
> >
> > Gary Gregory wrote:
> >
> >> Hi All:
> >>
> >> I'd like to propose the change below. This lets you get rid of type
> casts
> >> in call sites. You'll still get a ClassCastException if you code it
> wrong
> >> of course.
> >
> > +1
> >
> >> The compiler warning you'll get is valid, so do not think we should
> >> @SuppressWarning against it.
> >
> > Suppress it. It is only for us devs and it simply means that we know th=
e
> > risk and we accept it.
>
> If we do add @SuppressWarning, the reason for doing so must be
> documented in the code.
> And the method Javadoc should warn about any Exception that might be
> generated.
>

Please see trunk for some fresh comments.

Thank you,
Gary

>
> > - J=C3=B6rg
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>


--=20
E-Mail: garydgregory@gmail.com | ggregory@apache.org
JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

--e89a8ff1c378b6cdec04bd08e9f5--