commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: svn commit: r1309910 - in /commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3: ArrayUtilsRemoveMultipleTest.java BooleanUtilsTest.java EnumUtilsTest.java ObjectUtilsTest.java RangeTest.java
Date Fri, 06 Apr 2012 16:25:43 GMT
On 5 April 2012 16:52,  <ggregory@apache.org> wrote:
> Author: ggregory
> Date: Thu Apr  5 15:52:43 2012
> New Revision: 1309910
>
> URL: http://svn.apache.org/viewvc?rev=1309910&view=rev
> Log:
> Do not import *

I don't think it matters using a static wild-card import such as

import static org.junit.Assert.*;

Also, it's only test code.

I would not have bothered to fix this, but neither would I revert the fix.

> Modified:
>    commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/ArrayUtilsRemoveMultipleTest.java
>    commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/BooleanUtilsTest.java
>    commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/EnumUtilsTest.java
>    commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/ObjectUtilsTest.java
>    commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/RangeTest.java
>
> Modified: commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/ArrayUtilsRemoveMultipleTest.java
> URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/ArrayUtilsRemoveMultipleTest.java?rev=1309910&r1=1309909&r2=1309910&view=diff
> ==============================================================================
> --- commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/ArrayUtilsRemoveMultipleTest.java
(original)
> +++ commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/ArrayUtilsRemoveMultipleTest.java
Thu Apr  5 15:52:43 2012
> @@ -17,7 +17,11 @@
>
>  package org.apache.commons.lang3;
>
> -import static org.junit.Assert.*;
> +import static org.junit.Assert.assertArrayEquals;
> +import static org.junit.Assert.assertEquals;
> +import static org.junit.Assert.assertNotSame;
> +import static org.junit.Assert.assertNull;
> +import static org.junit.Assert.assertTrue;
>
>  import java.util.Arrays;
>
>
> Modified: commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/BooleanUtilsTest.java
> URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/BooleanUtilsTest.java?rev=1309910&r1=1309909&r2=1309910&view=diff
> ==============================================================================
> --- commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/BooleanUtilsTest.java
(original)
> +++ commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/BooleanUtilsTest.java
Thu Apr  5 15:52:43 2012
> @@ -16,7 +16,11 @@
>  */
>  package org.apache.commons.lang3;
>
> -import static org.junit.Assert.*;
> +import static org.junit.Assert.assertEquals;
> +import static org.junit.Assert.assertFalse;
> +import static org.junit.Assert.assertNotNull;
> +import static org.junit.Assert.assertSame;
> +import static org.junit.Assert.assertTrue;
>
>  import java.lang.reflect.Constructor;
>  import java.lang.reflect.Modifier;
>
> Modified: commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/EnumUtilsTest.java
> URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/EnumUtilsTest.java?rev=1309910&r1=1309909&r2=1309910&view=diff
> ==============================================================================
> --- commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/EnumUtilsTest.java
(original)
> +++ commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/EnumUtilsTest.java
Thu Apr  5 15:52:43 2012
> @@ -18,7 +18,9 @@
>  */
>  package org.apache.commons.lang3;
>
> -import static org.junit.Assert.*;
> +import static org.junit.Assert.assertEquals;
> +import static org.junit.Assert.assertFalse;
> +import static org.junit.Assert.assertTrue;
>
>  import java.util.ArrayList;
>  import java.util.EnumSet;
>
> Modified: commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/ObjectUtilsTest.java
> URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/ObjectUtilsTest.java?rev=1309910&r1=1309909&r2=1309910&view=diff
> ==============================================================================
> --- commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/ObjectUtilsTest.java
(original)
> +++ commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/ObjectUtilsTest.java
Thu Apr  5 15:52:43 2012
> @@ -16,7 +16,14 @@
>  */
>  package org.apache.commons.lang3;
>
> -import static org.junit.Assert.*;
> +import static org.junit.Assert.assertEquals;
> +import static org.junit.Assert.assertFalse;
> +import static org.junit.Assert.assertNotNull;
> +import static org.junit.Assert.assertNotSame;
> +import static org.junit.Assert.assertNull;
> +import static org.junit.Assert.assertSame;
> +import static org.junit.Assert.assertTrue;
> +import static org.junit.Assert.fail;
>
>  import java.lang.reflect.Constructor;
>  import java.lang.reflect.Modifier;
>
> Modified: commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/RangeTest.java
> URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/RangeTest.java?rev=1309910&r1=1309909&r2=1309910&view=diff
> ==============================================================================
> --- commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/RangeTest.java (original)
> +++ commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/RangeTest.java Thu
Apr  5 15:52:43 2012
> @@ -17,7 +17,12 @@
>
>  package org.apache.commons.lang3;
>
> -import static org.junit.Assert.*;
> +import static org.junit.Assert.assertEquals;
> +import static org.junit.Assert.assertFalse;
> +import static org.junit.Assert.assertNotNull;
> +import static org.junit.Assert.assertSame;
> +import static org.junit.Assert.assertTrue;
> +import static org.junit.Assert.fail;
>
>  import java.util.Comparator;
>
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message