commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Thomas Neidhart <thomas.neidh...@gmail.com>
Subject Re: [codec] fixing CODEC-96 breaks BC
Date Mon, 02 Apr 2012 15:35:46 GMT
On Mon, Apr 2, 2012 at 4:09 PM, Gary Gregory <garydgregory@gmail.com> wrote:

> WRT https://issues.apache.org/jira/browse/CODEC-96
>
> (Moving discussion to ML from JIRA)
>
> OK, I see the Clirr errors now after applying CODEX-96-2.patch locally. It
> looks like normal users would not be affected. The issue is only if a codec
> is used in some advanced scheme. I am not sure what user story that would
> be though. According to this issue, the bug was made from 1.3 to 1.4.
>
> We have choices:
>
> - Don't apply the patch and document Base-N codecs as thread-unsafe.
> - Apply the patch for 1.7 and document breakage.
>

+1

to be on the safe side, I would also implement the mark, reset,
markAvailable methods as outlined in the related issue.
I have found this while reviewing sebb's patch as the context is now
distinguished and it was clearer to see that this might be a problem.

I can provide a patch for this till tonight.



> - Apply the patch for 2.0 and document breakage.
>
> Thoughts?
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
> Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message