commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gary Gregory <garydgreg...@gmail.com>
Subject Re: [lang] SerializationUtils and generics
Date Fri, 06 Apr 2012 20:58:05 GMT
On Fri, Apr 6, 2012 at 12:44 PM, sebb <sebbaz@gmail.com> wrote:

> On 5 April 2012 16:38, Jörg Schaible <Joerg.Schaible@scalaris.com> wrote:
> > Hi Gary,
> >
> > Gary Gregory wrote:
> >
> >> Hi All:
> >>
> >> I'd like to propose the change below. This lets you get rid of type
> casts
> >> in call sites. You'll still get a ClassCastException if you code it
> wrong
> >> of course.
> >
> > +1
> >
> >> The compiler warning you'll get is valid, so do not think we should
> >> @SuppressWarning against it.
> >
> > Suppress it. It is only for us devs and it simply means that we know the
> > risk and we accept it.
>
> If we do add @SuppressWarning, the reason for doing so must be
> documented in the code.
> And the method Javadoc should warn about any Exception that might be
> generated.
>

Please see trunk for some fresh comments.

Thank you,
Gary

>
> > - Jörg
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>


-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message