Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (athena.apache.org: domain of sebbaz@gmail.com designates
 209.85.214.171 as permitted sender)
Received-SPF: pass (google.com: domain of sebbaz@gmail.com designates
 10.182.14.34 as permitted sender) client-ip=10.182.14.34;
MIME-Version: 1.0
In-Reply-To: <20120306091510.EB47723889FA@eris.apache.org>
References: <20120306091510.EB47723889FA@eris.apache.org>
Date: Tue, 6 Mar 2012 16:23:50 +0000
Message-ID: 
 <CAOGo0VbwXDRjk6z+wEOwgakLxWkZRn1EfC_4UkwzoAKnPibwiQ@mail.gmail.com>
Subject: Re: svn commit: r1297393 - /commons/proper/chain/trunk/pom.xml
From: sebb <sebbaz@gmail.com>
To: dev@commons.apache.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On 6 March 2012 09:15,  <simonetripodi@apache.org> wrote:
> Author: simonetripodi
> Date: Tue Mar =A06 09:15:10 2012
> New Revision: 1297393
>
> URL: http://svn.apache.org/viewvc?rev=3D1297393&view=3Drev
> Log:
> explicit use of the surefire-report plugin to aggregate test results
>
> Modified:
> =A0 =A0commons/proper/chain/trunk/pom.xml
> Modified: commons/proper/chain/trunk/pom.xml
> URL: http://svn.apache.org/viewvc/commons/proper/chain/trunk/pom.xml?rev=
=3D1297393&r1=3D1297392&r2=3D1297393&view=3Ddiff
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- commons/proper/chain/trunk/pom.xml (original)
> +++ commons/proper/chain/trunk/pom.xml Tue Mar =A06 09:15:10 2012
> @@ -122,6 +122,8 @@
> =A0 =A0 <commons.jira.pid>12310462</commons.jira.pid>
> =A0 =A0 <commons.osgi.import>!javax.portlet,*</commons.osgi.import>
> =A0 =A0 <commons.osgi.dynamicImport>javax.portlet</commons.osgi.dynamicIm=
port>
> +
> + =A0 =A0<surefire.version>2.12</surefire.version>

Commons Parent 23 has

    <commons.surefire.version>2.9</commons.surefire.version>

Would it work to override this instead?

If so, I think the build/plugin section could be dropped.

> =A0 </properties>
>
> =A0 <dependencyManagement>
> @@ -169,12 +171,17 @@
> =A0 =A0 =A0 =A0 =A0 </execution>
> =A0 =A0 =A0 =A0 </executions>
> =A0 =A0 =A0 </plugin>
> +
> + =A0 =A0 =A0<plugin>
> + =A0 =A0 =A0 =A0<groupId>org.apache.maven.plugins</groupId>
> + =A0 =A0 =A0 =A0<artifactId>maven-surefire-plugin</artifactId>
> + =A0 =A0 =A0 =A0<version>${surefire.version}</version>
> + =A0 =A0 =A0</plugin>

Possibly not needed, see above.

> =A0 =A0 </plugins>
> =A0 </build>
>
> =A0 <reporting>
> =A0 =A0 <plugins>
> -
> =A0 =A0 =A0 <plugin>
> =A0 =A0 =A0 =A0 <groupId>org.apache.maven.plugins</groupId>
> =A0 =A0 =A0 =A0 <artifactId>maven-changes-plugin</artifactId>
> @@ -194,6 +201,15 @@
>
> =A0 =A0 =A0 <plugin>
> =A0 =A0 =A0 =A0 <groupId>org.apache.maven.plugins</groupId>
> + =A0 =A0 =A0 =A0<artifactId>maven-surefire-report-plugin</artifactId>
> + =A0 =A0 =A0 =A0<version>${surefire.version}</version>
> + =A0 =A0 =A0 =A0<configuration>
> + =A0 =A0 =A0 =A0 =A0<aggregate>true</aggregate>
> + =A0 =A0 =A0 =A0</configuration>

The config section is not in CP23.
Perhaps need to consider if it should be added?
Should be done as a property, so can be overridden, but what would be
the best default?

> + =A0 =A0 =A0</plugin>
> +
> + =A0 =A0 =A0<plugin>
> + =A0 =A0 =A0 =A0<groupId>org.apache.maven.plugins</groupId>
> =A0 =A0 =A0 =A0 <artifactId>maven-checkstyle-plugin</artifactId>
> =A0 =A0 =A0 =A0 <version>2.9.1</version>
> =A0 =A0 =A0 =A0 <configuration>
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org