Return-Path: X-Original-To: apmail-commons-dev-archive@www.apache.org Delivered-To: apmail-commons-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0388D97FA for ; Fri, 23 Mar 2012 18:54:46 +0000 (UTC) Received: (qmail 18393 invoked by uid 500); 23 Mar 2012 18:54:46 -0000 Delivered-To: apmail-commons-dev-archive@commons.apache.org Received: (qmail 18289 invoked by uid 500); 23 Mar 2012 18:54:46 -0000 Mailing-List: contact dev-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Commons Developers List" Delivered-To: mailing list dev@commons.apache.org Received: (qmail 18280 invoked by uid 99); 23 Mar 2012 18:54:46 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 Mar 2012 18:54:46 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of thomas.neidhart@gmail.com designates 74.125.82.171 as permitted sender) Received: from [74.125.82.171] (HELO mail-we0-f171.google.com) (74.125.82.171) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 Mar 2012 18:54:38 +0000 Received: by werm1 with SMTP id m1so3469839wer.30 for ; Fri, 23 Mar 2012 11:54:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type :content-transfer-encoding; bh=TvNHKCc1c+C5/IAjv04pg2+IIziRglDvYETwqY4es80=; b=SiW85+gZ0SmIy2/KhNpfK++ThNSNdpoCAnweCI3oEuRiVfkRbJ9y/zJsp/ocHNl41I AvUqKR/7YKn3Jd0HQ9HNDFtp3z75pEz/IIETu086xoLvJuheoR7EZGSVPQvyFcauk/tq UXePp8+a10SE8760JJi/Y/BbaD9ksy04oV0b7YRuGczZ5XpthwuGB9ukTpPB8cjlRk9y WqBqo7QiwKOw/QO1ssNHoFrcsc0IvTA4q/7nZclR3X5hA5OJe5TmcS2bxvb2XwgURN63 Xd+CLaKJsTl2MTvKPiiMfFDHaCJ25vG8c+RzahKjBYnEXyxxri880YnFk+dCESGXeEEk ZSxg== Received: by 10.180.106.9 with SMTP id gq9mr8851063wib.17.1332528857300; Fri, 23 Mar 2012 11:54:17 -0700 (PDT) Received: from [192.168.1.3] (ip-213-49-233-229.dsl.scarlet.be. [213.49.233.229]) by mx.google.com with ESMTPS id j3sm26413773wiw.1.2012.03.23.11.54.16 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 23 Mar 2012 11:54:16 -0700 (PDT) Message-ID: <4F6CC6D7.9060401@gmail.com> Date: Fri, 23 Mar 2012 19:54:15 +0100 From: Thomas Neidhart User-Agent: Mozilla/5.0 (X11; Linux i686; rv:10.0.2) Gecko/20120216 Thunderbird/10.0.2 MIME-Version: 1.0 To: Commons Developers List Subject: Re: svn commit: r1304377 - /commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/binary/HexTest.java References: <20120323143957.3CABC238897A@eris.apache.org> In-Reply-To: <20120323143957.3CABC238897A@eris.apache.org> X-Enigmail-Version: 1.4 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org On 03/23/2012 03:39 PM, sebb@apache.org wrote: > Author: sebb > Date: Fri Mar 23 14:39:56 2012 > New Revision: 1304377 > > URL: http://svn.apache.org/viewvc?rev=1304377&view=rev > Log: > Refix bug introduced in r1304137 > (accidentally converted assertFalse to assertEquals) > > Modified: > commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/binary/HexTest.java > > Modified: commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/binary/HexTest.java > URL: http://svn.apache.org/viewvc/commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/binary/HexTest.java?rev=1304377&r1=1304376&r2=1304377&view=diff > ============================================================================== > --- commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/binary/HexTest.java (original) > +++ commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/binary/HexTest.java Fri Mar 23 14:39:56 2012 > @@ -341,7 +341,7 @@ public class HexTest { > actual = Hex.encodeHex(b, true); > assertEquals(expected, new String(actual)); > actual = Hex.encodeHex(b, false); > - assertEquals(expected.toUpperCase(), new String(actual)); > + assertFalse(expected.equals(new String(actual))); > } didn't like the way I fixed it? ;-) Thomas --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org For additional commands, e-mail: dev-help@commons.apache.org