commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gary Gregory <garydgreg...@gmail.com>
Subject Re: [codec] Release 1.7
Date Mon, 19 Mar 2012 19:50:24 GMT
On Mon, Mar 19, 2012 at 3:08 PM, Thomas Neidhart
<thomas.neidhart@gmail.com>wrote:

> On 03/19/2012 05:38 PM, Gary Gregory wrote:
>
> > Ok, can you: (1) back out the QuotedPrintableCodec changes and (2)
> complete
> > Codec-130?
>
> (1) I am working on it, svn seems to be dead over here in EU
>    The reverted diff will be attached to the issue
>
> (2) I managed to commit it, would be nice if you could review the
>    changes, the CC for the new methods is 100% (missing some coverage
>    for read though)
>

On (2): Looks good. I committed a couple of tweaks.

Why should we have the almost same impl InflaterIS WRT the limit on the
size of the input skip param? What if I want to skip in some giant
multi-gig file (unlikely perhaps)?

Gary

>
> Thomas
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>


-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message