commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gary Gregory <garydgreg...@gmail.com>
Subject Re: svn commit: r1298588 - /commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/language/NysiisTest.java
Date Thu, 08 Mar 2012 22:03:10 GMT
Thomas:

It seems to me that we do not need both testDropBy and testDropBy2.

I initially created testDropBy2 as a way to work through the "Original" and
"Modified" examples from the site.

So unless you think we need both, let get rid of testDropBy.

Thoughts?

Gary

On Thu, Mar 8, 2012 at 4:19 PM, <tn@apache.org> wrote:

> Author: tn
> Date: Thu Mar  8 21:19:56 2012
> New Revision: 1298588
>
> URL: http://svn.apache.org/viewvc?rev=1298588&view=rev
> Log:
> fixed spelling in NysiisTest
>
> Modified:
>
>  commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/language/NysiisTest.java
>
> Modified:
> commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/language/NysiisTest.java
> URL:
> http://svn.apache.org/viewvc/commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/language/NysiisTest.java?rev=1298588&r1=1298587&r2=1298588&view=diff
>
> ==============================================================================
> ---
> commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/language/NysiisTest.java
> (original)
> +++
> commons/proper/codec/trunk/src/test/java/org/apache/commons/codec/language/NysiisTest.java
> Thu Mar  8 21:19:56 2012
> @@ -137,29 +137,29 @@ public class NysiisTest extends StringEn
>         // Algorithm (taken from www.dropby.com/NYSIIS.html):
>         //
>         // 1.  Transcode first characters of name:
> -        //    MAC »   MCC
> -        //    KN  »   NN
> -        //    K   »   C
> -        //    PH  »   FF
> -        //    PF  »   FF
> -        //    SCH »   SSS
> +        //    MAC >   MCC
> +        //    KN  >   NN
> +        //    K   >   C
> +        //    PH  >   FF
> +        //    PF  >   FF
> +        //    SCH >   SSS
>         //
>         // 2.  Transcode last characters of name:
> -        //    EE, IE  »   Y
> -        //    DT,RT,RD,NT,ND  »   D
> +        //    EE, IE  >   Y
> +        //    DT,RT,RD,NT,ND  >   D
>         //
>         // 3.  First character of key = first character of name.
>         //
>         // 4.  Transcode remaining characters by following these rules,
> incrementing by one character each time:
> -        //   4a.   EV  »   AF  else A,E,I,O,U » A
> -        //   4b.   Q   »   G
> -        //   4c.   Z   »   S
> -        //   4d.   M   »   N
> -        //   4e.   KN  »   N   else K » C
> -        //   4f.   SCH     »   SSS
> -        //   4g.   PH  »   FF
> -        //   4h.   H   »   If previous or next is nonvowel, previous
> -        //   4i.   W   »   If previous is vowel, previous
> +        //   4a.   EV  >   AF  else A,E,I,O,U > A
> +        //   4b.   Q   >   G
> +        //   4c.   Z   >   S
> +        //   4d.   M   >   N
> +        //   4e.   KN  >   N   else K > C
> +        //   4f.   SCH >   SSS
> +        //   4g.   PH  >   FF
> +        //   4h.   H   >   If previous or next is nonvowel, previous
> +        //   4i.   W   >   If previous is vowel, previous
>         //   4j.   Add current to key if current != last key character
>         //
>         // 5.  If last character is S, remove it
> @@ -186,7 +186,7 @@ public class NysiisTest extends StringEn
>                         new String[] { "PHILLIPSON", "FALAPSAN" }, //
> Original: FFALAP[SAN]
>                         // violates 4j: see also KNUTH
>                         new String[] { "PFEISTER", "FASTAR" }, //
> Original: FFASTA[R]
> -                        // violoates 4j: see also KNUTH
> +                        // violates 4j: see also KNUTH
>                         new String[] { "SCHOENHOEFT", "SANAFT" }, //
> Original: SSANAF[T]
>                         //
> http://www.dropby.com/indexLF.html?content=/NYSIIS.html
>                         // 2.Transcode last characters of name:
> @@ -213,7 +213,7 @@ public class NysiisTest extends StringEn
>                         // violates 4h: the H should be transcoded to S
> and thus ignored as
>                         // the first key character is also S
>                         new String[] { "SHRIVER", "SRAVAR" }, // Original:
> SHRAVA[R]
> -                        // same as KOEHN, the L gets mysteriously lost,
> the correct one
> +                        // same as KOEHN, the L gets mysteriously lost
>                         new String[] { "KUHL", "CAL" }, // Original: C
>                         new String[] { "RAWSON", "RASAN" },
>                         // If last character is S, remove it
>
>
>


-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message