commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benedikt Ritter <benerit...@googlemail.com>
Subject Re: svn commit: r1301852 - in /commons/proper/csv/trunk/src: main/java/org/apache/commons/csv/ test/java/org/apache/commons/csv/
Date Sat, 17 Mar 2012 12:52:20 GMT
Am 17. März 2012 13:12 schrieb sebb <sebbaz@gmail.com>:
> On 17 March 2012 01:39,  <ebourg@apache.org> wrote:
>> Author: ebourg
>> Date: Sat Mar 17 01:39:04 2012
>> New Revision: 1301852
>>
>> URL: http://svn.apache.org/viewvc?rev=1301852&view=rev
>> Log:
>> Header support (CSV-65)
>>
>> Added:
>>    commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVRecord.java
>> Modified:
>>    commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVFormat.java
>>    commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVParser.java
>>    commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/package.html
>>    commons/proper/csv/trunk/src/test/java/org/apache/commons/csv/CSVFormatTest.java
>>    commons/proper/csv/trunk/src/test/java/org/apache/commons/csv/CSVParserTest.java
>>    commons/proper/csv/trunk/src/test/java/org/apache/commons/csv/CSVPrinterTest.java
>
> <snip/>
>
>> Added: commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVRecord.java
>> URL: http://svn.apache.org/viewvc/commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVRecord.java?rev=1301852&view=auto
>> ==============================================================================
>> --- commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVRecord.java
(added)
>> +++ commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVRecord.java
Sat Mar 17 01:39:04 2012
>> @@ -0,0 +1,87 @@
> <snip/>
>
>> + *
>> + * @author Emmanuel Bourg
>
> The ASF deprecates @author comments in code; these should go in the
> pom / release notes / changes instead.
>
>> + */
>> +public class CSVRecord implements Serializable, Iterable<String> {
>> +
>
> Does the class need to be public?
>

Yes, otherwise CSVParser.getRecords() would be rather senseless. Users
wouldn't not be able to assign Records to a variable.

> Does it need to be Serializable?
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message