commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Simone Tripodi <simonetrip...@apache.org>
Subject Re: svn commit: r1297393 - /commons/proper/chain/trunk/pom.xml
Date Wed, 07 Mar 2012 07:40:32 GMT
Hi Seb!

>> +
>> +    <surefire.version>2.12</surefire.version>
>
> Commons Parent 23 has
>
>    <commons.surefire.version>2.9</commons.surefire.version>
>
> Would it work to override this instead?

yeah! didn't notice it, it does!

>> +        <artifactId>maven-surefire-report-plugin</artifactId>
>> +        <version>${surefire.version}</version>
>> +        <configuration>
>> +          <aggregate>true</aggregate>
>> +        </configuration>
>
> The config section is not in CP23.
> Perhaps need to consider if it should be added?
> Should be done as a property, so can be overridden, but what would be
> the best default?

IMHO better to keep `false` as default value, since it is not usual
that commons components are splitted in multi-modules, but overridible
via a dedicated property, such as

<commons.surefire-report.aggregate>true</commons.surefire-report.aggregate>

or a better name. WDYT?
thanks for reviewing!
-Simo

http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/



On Tue, Mar 6, 2012 at 5:23 PM, sebb <sebbaz@gmail.com> wrote:
> On 6 March 2012 09:15,  <simonetripodi@apache.org> wrote:
>> Author: simonetripodi
>> Date: Tue Mar  6 09:15:10 2012
>> New Revision: 1297393
>>
>> URL: http://svn.apache.org/viewvc?rev=1297393&view=rev
>> Log:
>> explicit use of the surefire-report plugin to aggregate test results
>>
>> Modified:
>>    commons/proper/chain/trunk/pom.xml
>> Modified: commons/proper/chain/trunk/pom.xml
>> URL: http://svn.apache.org/viewvc/commons/proper/chain/trunk/pom.xml?rev=1297393&r1=1297392&r2=1297393&view=diff
>> ==============================================================================
>> --- commons/proper/chain/trunk/pom.xml (original)
>> +++ commons/proper/chain/trunk/pom.xml Tue Mar  6 09:15:10 2012
>> @@ -122,6 +122,8 @@
>>     <commons.jira.pid>12310462</commons.jira.pid>
>>     <commons.osgi.import>!javax.portlet,*</commons.osgi.import>
>>     <commons.osgi.dynamicImport>javax.portlet</commons.osgi.dynamicImport>

>
> If so, I think the build/plugin section could be dropped.
>
>>   </properties>
>>
>>   <dependencyManagement>
>> @@ -169,12 +171,17 @@
>>           </execution>
>>         </executions>
>>       </plugin>
>> +
>> +      <plugin>
>> +        <groupId>org.apache.maven.plugins</groupId>
>> +        <artifactId>maven-surefire-plugin</artifactId>
>> +        <version>${surefire.version}</version>
>> +      </plugin>
>
> Possibly not needed, see above.
>
>>     </plugins>
>>   </build>
>>
>>   <reporting>
>>     <plugins>
>> -
>>       <plugin>
>>         <groupId>org.apache.maven.plugins</groupId>
>>         <artifactId>maven-changes-plugin</artifactId>
>> @@ -194,6 +201,15 @@
>>
>>       <plugin>
>>         <groupId>org.apache.maven.plugins</groupId>
>> +        <artifactId>maven-surefire-report-plugin</artifactId>
>> +        <version>${surefire.version}</version>
>> +        <configuration>
>> +          <aggregate>true</aggregate>
>> +        </configuration>
>
> The config section is not in CP23.
> Perhaps need to consider if it should be added?
> Should be done as a property, so can be overridden, but what would be
> the best default?
>
>> +      </plugin>
>> +
>> +      <plugin>
>> +        <groupId>org.apache.maven.plugins</groupId>
>>         <artifactId>maven-checkstyle-plugin</artifactId>
>>         <version>2.9.1</version>
>>         <configuration>
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message