commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Luc Maisonobe <Luc.Maison...@free.fr>
Subject Re: [Math] New warnings from "FindBugs"
Date Thu, 01 Mar 2012 20:29:49 GMT
Le 01/03/2012 15:16, Gilles Sadowski a écrit :
> Hi.

Hi Gilles,

> 
> The version upgrade of the FindBugs plugin led to new discoveries some of
> which are potentially serious bugs:
> 
> * org.apache.commons.math3.ode.nonstiff.GraggBulirschStoerIntegrator: Was
>   method "setStepsizeControl" (note the spelling) intended to override
>   "setStepSizeControl" defined in the parent class?

No, this is a completely different method. The name and signature
similarity was unfortunate ... I have renamed this method.

Fixed in r1295772.

Sorry for the confusion.

Luc

> 
> * org.apache.commons.math3.linear.SymmLQ: Yet another problem with a
>   probably unnecessary "Serializable"...
> 
> * org.apache.commons.math3.genetics.Chromosome: At line 31 (and 43, where
>   FindBugs warns about strict floating point comparison), is the value
>   intended to be the most negative one, instead of "Double.MIN_VALUE" (which
>   is positive)?
> 
> * org.apache.commons.math3.random.EmpiricalDistribution (lines 213, 221,
>   242, 246) and  org.apache.commons.math3.random.ValueServer (line 270):
>   From "FindBugs":
>    Dm: Reliance on default encoding (DM_DEFAULT_ENCODING)
> 
>    Found a call to a method which will perform a byte to String (or String to
>    byte) conversion, and will assume that the default platform encoding is
>    suitable. This will cause the application behaviour to vary between
>    platforms. Use an alternative API and specify a charset name or Charset
>    object explicitly. 
> 
> 
> I think that the last one could be fixed later (unless someone knows how to
> solve it). But for the others, please have look ASAP.
> 
> 
> Thanks,
> Gilles
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message