commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Thomas Neidhart <thomas.neidh...@gmail.com>
Subject Re: [graph] Doubts on DFS algorithm implementation
Date Thu, 01 Mar 2012 18:32:36 GMT
On 03/01/2012 07:06 PM, Marco Speranza wrote:
> Hi Thomas,
> 
> I run the test and it seems that the BSF explore twice the same edge. 
> 
> ====
> 
> Tests run: 3, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.025 sec <<<
FAILURE!
> 
> Results :
> 
> Tests in error: 
>   verifyBreadthFirstSearch(org.apache.commons.graph.visit.VisitTestCase): Edge x <->
y() is already present in the Graph
> 
> Tests run: 109, Failures: 0, Errors: 1, Skipped: 0
> 
> ====
> 
> I think that we have to add also a list of the visited edges to avoid that. 
> 
> Do you agree with me?

yes, sorry, I was too fast committing. Added an extra check to prevent
discovering multiple edges that lead to the same (already visited) vertex.

Thomas

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message