commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benedikt Ritter <b...@systemoutprintln.de>
Subject [SANDBOX][BeanUtils2] Improve implemenation of equals() on AccessibleObjectDescriptor
Date Thu, 01 Mar 2012 14:09:20 GMT
Hi,

I just ran the eclipse FindBugs plugin with default configuration on 
BeanUtils2 and it pointed me to equals() in 
AccessibleObjectRegistry.AccessibleObjectDescriptor, reporting that the 
cast in line 535

AccessibleObjectDescriptor other = (AccessibleObjectDescriptor) obj;

is not checked for null.
Now I'd like to implement equals() like it is shown in Effective Java. 
Are there any arguments against changing the implementation that way?

Regards,
Benedikt

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message