commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilles Sadowski <gil...@harfang.homelinux.org>
Subject Re: [ALL] Commons Parent reports
Date Tue, 13 Mar 2012 13:09:32 GMT
On Tue, Mar 13, 2012 at 01:39:40PM +0100, Torsten Curdt wrote:
> I find checkstyle to be not very useful. It's more hassle than it's
> worth. It's like pointing fingers instead of helping. If you want to
> foster a certain code style provide eclipse and intellij formatter
> settings instead - that's actually helping. Especially if you run them
> before a release.

CheckStyle reports should be checked regularly. Only doing so just before a
release indeed leads to a lot of tedious work, because coders did not
respect the basic, agreed on, style.

I don't use an IDE, so for me, CheckStyle helps but formatter IDE plugins
would not. Our mileage do vary but the end-product (clean code) should not.  

As said in another post, you can always disable reports that you find
unhelpful.

> The basic code style is like logging - people spent just wait too much
> time on this.

The real problem is that some coders do not do their part of the job when
they commit badly formatted code.
Those whose spend too much time are the ones who try to clean up the mess
afterwards.
CheckStyle indeed points a finger to the right person, which IMHO helps by
making this person aware that he should fix it.

> Thinks we really should care about are in the findbugs
> and PMD report. I don't see why we should make checkstyle part of the
> projects by default.

They are all useful in different ways.

Best regards,
Gilles

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message