commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilles Sadowski <gil...@harfang.homelinux.org>
Subject Re: [Math] New warnings from "FindBugs"
Date Thu, 01 Mar 2012 22:27:50 GMT
Hello Luc.

> > 
> > The version upgrade of the FindBugs plugin led to new discoveries some of
> > which are potentially serious bugs:
> > 
> > * org.apache.commons.math3.ode.nonstiff.GraggBulirschStoerIntegrator: Was
> >   method "setStepsizeControl" (note the spelling) intended to override
> >   "setStepSizeControl" defined in the parent class?
> 
> No, this is a completely different method. The name and signature
> similarity was unfortunate ... I have renamed this method.
> 
> Fixed in r1295772.

Thanks.

> [...]

> > * org.apache.commons.math3.random.EmpiricalDistribution (lines 213, 221,
> >   242, 246) and  org.apache.commons.math3.random.ValueServer (line 270):
> >   From "FindBugs":
> >    Dm: Reliance on default encoding (DM_DEFAULT_ENCODING)
> > 
> >    Found a call to a method which will perform a byte to String (or String to
> >    byte) conversion, and will assume that the default platform encoding is
> >    suitable. This will cause the application behaviour to vary between
> >    platforms. Use an alternative API and specify a charset name or Charset
> >    object explicitly. 
> > 
> > 
> > I think that the last one could be fixed later (unless someone knows how to
> > solve it). [...]

OK to leave those?


Gilles

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message