commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilles Sadowski <gil...@harfang.homelinux.org>
Subject Re: [Math] New warnings from "FindBugs"
Date Thu, 01 Mar 2012 22:26:24 GMT
Hello Sébastien.

> > 
> > >
> > > * org.apache.commons.math3.linear.SymmLQ: Yet another problem with a
> > >  probably unnecessary "Serializable"...
> > >
> > In fact, it comes from a nested class which extends EventObject, so it
> > must be (unfortunately) serializable. I'll look into it.
> 
> Then, it seems that you can define it as "static", and it will make FindBugs
> happy, I think. [The problem is that it is a "plain" inner class, in a
> non-serializable class.]
> 

I've performed this change and also had to make the "state" field
"transient" because "State" is not "Serializable" and it cannot be
since "RealLinearOperator" is not "Serializable" and cannot be (IIUC).[1]
[At first sight, all this confirms that we should stay away from
"Serializable". :-}]


Best,
Gilles

[1] This quiets "FindBugs", and since that class is a private inner class,
    you'll have the possiblity to handle this in another way for 3.1.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message