Return-Path: X-Original-To: apmail-commons-dev-archive@www.apache.org Delivered-To: apmail-commons-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5EC0290D3 for ; Fri, 17 Feb 2012 21:13:21 +0000 (UTC) Received: (qmail 16971 invoked by uid 500); 17 Feb 2012 21:13:20 -0000 Delivered-To: apmail-commons-dev-archive@commons.apache.org Received: (qmail 16866 invoked by uid 500); 17 Feb 2012 21:13:20 -0000 Mailing-List: contact dev-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Commons Developers List" Delivered-To: mailing list dev@commons.apache.org Received: (qmail 16855 invoked by uid 99); 17 Feb 2012 21:13:20 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 17 Feb 2012 21:13:20 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of ralph.goers@dslextreme.com designates 209.85.210.43 as permitted sender) Received: from [209.85.210.43] (HELO mail-pz0-f43.google.com) (209.85.210.43) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 17 Feb 2012 21:13:13 +0000 Received: by damc16 with SMTP id c16so23274955dam.30 for ; Fri, 17 Feb 2012 13:12:51 -0800 (PST) Received-SPF: pass (google.com: domain of ralph.goers@dslextreme.com designates 10.68.201.101 as permitted sender) client-ip=10.68.201.101; Authentication-Results: mr.google.com; spf=pass (google.com: domain of ralph.goers@dslextreme.com designates 10.68.201.101 as permitted sender) smtp.mail=ralph.goers@dslextreme.com Received: from mr.google.com ([10.68.201.101]) by 10.68.201.101 with SMTP id jz5mr27414604pbc.152.1329513171992 (num_hops = 1); Fri, 17 Feb 2012 13:12:51 -0800 (PST) Received: by 10.68.201.101 with SMTP id jz5mr22455199pbc.152.1329513171893; Fri, 17 Feb 2012 13:12:51 -0800 (PST) Received: from [192.168.1.64] (99-180-69-21.lightspeed.irvnca.sbcglobal.net. [99.180.69.21]) by mx.google.com with ESMTPS id u8sm6056868pbr.53.2012.02.17.13.12.50 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 17 Feb 2012 13:12:51 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Apple Message framework v1084) Subject: Re: svn commit: r1245166 - in /commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2: provider/ provider/http/ provider/https/ provider/ram/ provider/sftp/ provider/tar/ util/ From: Ralph Goers In-Reply-To: Date: Fri, 17 Feb 2012 13:12:48 -0800 Content-Transfer-Encoding: quoted-printable Message-Id: References: <20120216203805.C199623889EC@eris.apache.org> <60F65E1E-7F9E-414C-A3C6-F27533A9D7F6@dslextreme.com> To: "Commons Developers List" X-Mailer: Apple Mail (2.1084) X-Gm-Message-State: ALoCoQlZnlRj3UwnbtMugLZmfNRuJQL6L2BSa3y3w9tx++OS48fxiWfEDqMx2jHP+GEWP3iVBvZ1 X-Virus-Checked: Checked by ClamAV on apache.org Really? I've gotten so used to putting the '{' at the end of the line = that I assumed VFS was that way. =20 Ralph On Feb 17, 2012, at 1:05 PM, Gary Gregory wrote: > On Fri, Feb 17, 2012 at 11:33 AM, Ralph Goers = wrote: >=20 >> I'm confused as to why you are having to fix so many checkstyle = issues. I >> had thought I had them down to just a couple of classes. In fact, = putting >> the curly brace on the next line should cause a checkstyle error. Are = you >> using the checktyle configuration that is in the project which is = used to >> build the checkstyle report for the web site? >>=20 >=20 > Yes, all I am doing it: "m3 site". >=20 > I do not like the stype of { on a line by iteself but all of VFS is = coded > that way. >=20 > Gary >=20 >=20 >>=20 >> Ralph >>=20 >> On Feb 16, 2012, at 12:38 PM, ggregory@apache.org wrote: >>=20 >>> Author: ggregory >>> Date: Thu Feb 16 20:38:04 2012 >>> New Revision: 1245166 >>>=20 >>> URL: http://svn.apache.org/viewvc?rev=3D1245166&view=3Drev >>> Log: >>> Fix Checkstyle issues. >>>=20 >>> Modified: >>>=20 >> = commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provid= er/AbstractFileName.java >>>=20 >> = commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provid= er/AbstractFileObject.java >>>=20 >> = commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provid= er/DefaultFileContent.java >>>=20 >> = commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provid= er/http/HttpFileNameParser.java >>>=20 >> = commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provid= er/https/HttpsFileNameParser.java >>>=20 >> = commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provid= er/ram/RamFileObject.java >>>=20 >> = commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provid= er/sftp/SftpClientFactory.java >>>=20 >> = commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provid= er/sftp/SftpFileObject.java >>>=20 >> = commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provid= er/sftp/SftpFileSystem.java >>>=20 >> = commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provid= er/sftp/SftpFileSystemConfigBuilder.java >>>=20 >> = commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provid= er/tar/TarFileSystem.java >>>=20 >> = commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/util/M= essages.java >>>=20 >>> Modified: >> = commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provid= er/AbstractFileName.java >>> URL: >> = http://svn.apache.org/viewvc/commons/proper/vfs/trunk/core/src/main/java/o= rg/apache/commons/vfs2/provider/AbstractFileName.java?rev=3D1245166&r1=3D1= 245165&r2=3D1245166&view=3Ddiff >>>=20 >> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >>> --- >> = commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provid= er/AbstractFileName.java >> (original) >>> +++ >> = commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provid= er/AbstractFileName.java >> Thu Feb 16 20:38:04 2012 >>> @@ -454,7 +454,8 @@ public abstract class AbstractFileName i >>> * @see #getType() >>> * @see FileType#FILE >>> */ >>> - public boolean isFile() throws FileSystemException { >>> + public boolean isFile() throws FileSystemException >>> + { >>> // Use equals instead of =3D=3D to avoid any class loader = worries. >>> return FileType.FILE.equals(this.getType()); >>> } >>>=20 >>> Modified: >> = commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provid= er/AbstractFileObject.java >>> URL: >> = http://svn.apache.org/viewvc/commons/proper/vfs/trunk/core/src/main/java/o= rg/apache/commons/vfs2/provider/AbstractFileObject.java?rev=3D1245166&r1=3D= 1245165&r2=3D1245166&view=3Ddiff >>>=20 >> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >>> --- >> = commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provid= er/AbstractFileObject.java >> (original) >>> +++ >> = commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provid= er/AbstractFileObject.java >> Thu Feb 16 20:38:04 2012 >>> @@ -518,7 +518,8 @@ public abstract class AbstractFileObject >>> * @see #getType() >>> * @see FileType#FILE >>> */ >>> - public boolean isFile() throws FileSystemException { >>> + public boolean isFile() throws FileSystemException >>> + { >>> // Use equals instead of =3D=3D to avoid any class loader = worries. >>> return FileType.FILE.equals(this.getType()); >>> } >>> @@ -531,7 +532,8 @@ public abstract class AbstractFileObject >>> * @see #getType() >>> * @see FileType#FOLDER >>> */ >>> - public boolean isFolder() throws FileSystemException { >>> + public boolean isFolder() throws FileSystemException >>> + { >>> // Use equals instead of =3D=3D to avoid any class loader = worries. >>> return FileType.FOLDER.equals(this.getType()); >>> } >>> @@ -623,7 +625,8 @@ public abstract class AbstractFileObject >>> try >>> { >>> return listFiles(Selectors.SELECT_ALL).iterator(); >>> - } catch (FileSystemException e) >>> + } >>> + catch (FileSystemException e) >>> { >>> throw new IllegalStateException(e); >>> } >>> @@ -929,7 +932,7 @@ public abstract class AbstractFileObject >>> } >>>=20 >>> /** >>> - * Deletes this file, and all children matching the {@code = selector} >>> + * Deletes this file, and all children matching the {@code >> selector}. >>> * >>> * @param selector The FileSelector. >>> * @return the number of deleted files. >>> @@ -1079,11 +1082,12 @@ public abstract class AbstractFileObject >>> } >>>=20 >>> /** >>> - * Compares two FileObjects (ignores case) >>> + * Compares two FileObjects (ignores case). >>> */ >>> public int compareTo(FileObject fo) >>> { >>> - if (fo =3D=3D null) { >>> + if (fo =3D=3D null) >>> + { >>> return 1; >>> } >>> return this.toString().compareToIgnoreCase(fo.toString()); >>> @@ -1091,6 +1095,7 @@ public abstract class AbstractFileObject >>>=20 >>> /** >>> * Copies another file to this file. >>> + * >>> * @param file The FileObject to copy. >>> * @param selector The FileSelector. >>> * @throws FileSystemException if an error occurs. >>>=20 >>> Modified: >> = commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provid= er/DefaultFileContent.java >>> URL: >> = http://svn.apache.org/viewvc/commons/proper/vfs/trunk/core/src/main/java/o= rg/apache/commons/vfs2/provider/DefaultFileContent.java?rev=3D1245166&r1=3D= 1245165&r2=3D1245166&view=3Ddiff >>>=20 >> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >>> --- >> = commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provid= er/DefaultFileContent.java >> (original) >>> +++ >> = commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provid= er/DefaultFileContent.java >> Thu Feb 16 20:38:04 2012 >>> @@ -310,7 +310,7 @@ public final class DefaultFileContent im >>> } >>> catch (final Exception e) >>> { >>> - throw new >> FileSystemException("vfs.provider/set-attribute.error", e,attrName, >> fileObject); >>> + throw new >> FileSystemException("vfs.provider/set-attribute.error", e, attrName, >> fileObject); >>> } >>>=20 >>> if (attrs !=3D null) >>>=20 >>> Modified: >> = commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provid= er/http/HttpFileNameParser.java >>> URL: >> = http://svn.apache.org/viewvc/commons/proper/vfs/trunk/core/src/main/java/o= rg/apache/commons/vfs2/provider/http/HttpFileNameParser.java?rev=3D1245166= &r1=3D1245165&r2=3D1245166&view=3Ddiff >>>=20 >> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >>> --- >> = commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provid= er/http/HttpFileNameParser.java >> (original) >>> +++ >> = commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provid= er/http/HttpFileNameParser.java >> Thu Feb 16 20:38:04 2012 >>> @@ -26,7 +26,7 @@ import org.apache.commons.vfs2.provider. >>> public class HttpFileNameParser extends URLFileNameParser >>> { >>> private static final int DEFAULT_PORT =3D 80; >>> - >>> + >>> private static final HttpFileNameParser INSTANCE =3D new >> HttpFileNameParser(); >>>=20 >>> public HttpFileNameParser() >>>=20 >>> Modified: >> = commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provid= er/https/HttpsFileNameParser.java >>> URL: >> = http://svn.apache.org/viewvc/commons/proper/vfs/trunk/core/src/main/java/o= rg/apache/commons/vfs2/provider/https/HttpsFileNameParser.java?rev=3D12451= 66&r1=3D1245165&r2=3D1245166&view=3Ddiff >>>=20 >> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >>> --- >> = commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provid= er/https/HttpsFileNameParser.java >> (original) >>> +++ >> = commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provid= er/https/HttpsFileNameParser.java >> Thu Feb 16 20:38:04 2012 >>> @@ -26,7 +26,7 @@ import org.apache.commons.vfs2.provider. >>> public class HttpsFileNameParser extends URLFileNameParser >>> { >>> private static final int DEFAULT_PORT =3D 443; >>> - >>> + >>> private static final HttpsFileNameParser INSTANCE =3D new >> HttpsFileNameParser(); >>>=20 >>> public HttpsFileNameParser() >>>=20 >>> Modified: >> = commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provid= er/ram/RamFileObject.java >>> URL: >> = http://svn.apache.org/viewvc/commons/proper/vfs/trunk/core/src/main/java/o= rg/apache/commons/vfs2/provider/ram/RamFileObject.java?rev=3D1245166&r1=3D= 1245165&r2=3D1245166&view=3Ddiff >>>=20 >> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >>> --- >> = commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provid= er/ram/RamFileObject.java >> (original) >>> +++ >> = commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provid= er/ram/RamFileObject.java >> Thu Feb 16 20:38:04 2012 >>> @@ -136,7 +136,7 @@ public class RamFileObject extends Abstr >>> protected void doDelete() throws Exception >>> { >>>=20 >>> - if (this.isContentOpen()) >>> + if (this.isContentOpen()) >>> { >>> throw new FileSystemException(this.getName() + " cannot = be >> deleted while the file is openg"); >>> } >>>=20 >>> Modified: >> = commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provid= er/sftp/SftpClientFactory.java >>> URL: >> = http://svn.apache.org/viewvc/commons/proper/vfs/trunk/core/src/main/java/o= rg/apache/commons/vfs2/provider/sftp/SftpClientFactory.java?rev=3D1245166&= r1=3D1245165&r2=3D1245166&view=3Ddiff >>>=20 >> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >>> --- >> = commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provid= er/sftp/SftpClientFactory.java >> (original) >>> +++ >> = commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provid= er/sftp/SftpClientFactory.java >> Thu Feb 16 20:38:04 2012 >>> @@ -296,7 +296,8 @@ public final class SftpClientFactory >>>=20 >>> private static class JSchLogger implements Logger >>> { >>> - public boolean isEnabled(int level) { >>> + public boolean isEnabled(int level) >>> + { >>> switch (level) >>> { >>> case FATAL: >>> @@ -315,7 +316,8 @@ public final class SftpClientFactory >>> } >>> } >>>=20 >>> - public void log(int level, String msg) { >>> + public void log(int level, String msg) >>> + { >>> switch (level) >>> { >>> case FATAL: >>>=20 >>> Modified: >> = commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provid= er/sftp/SftpFileObject.java >>> URL: >> = http://svn.apache.org/viewvc/commons/proper/vfs/trunk/core/src/main/java/o= rg/apache/commons/vfs2/provider/sftp/SftpFileObject.java?rev=3D1245166&r1=3D= 1245165&r2=3D1245166&view=3Ddiff >>>=20 >> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >>> --- >> = commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provid= er/sftp/SftpFileObject.java >> (original) >>> +++ >> = commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provid= er/sftp/SftpFileObject.java >> Thu Feb 16 20:38:04 2012 >>> @@ -53,6 +53,8 @@ import com.jcraft.jsch.SftpException; >>> */ >>> public class SftpFileObject extends AbstractFileObject >>> { >>> + private static final long MOD_TIME_FACTOR =3D 1000L; >>> + >>> private final SftpFileSystem fileSystem; >>> private SftpATTRS attrs; >>> private final String relPath; >>> @@ -75,7 +77,10 @@ public class SftpFileObject extends Abst >>> attrs =3D null; >>> } >>>=20 >>> - /** @since 2.0 */ >>> + /** >>> + * @throws FileSystemException if error occurs. >>> + * @since 2.0 >>> + */ >>> @Override >>> public void refresh() throws FileSystemException >>> { >>> @@ -223,7 +228,7 @@ public class SftpFileObject extends Abst >>> throw new FileSystemException( >>> "vfs.provider.sftp/unknown-modtime.error"); >>> } >>> - return attrs.getMTime() * 1000L; >>> + return attrs.getMTime() * MOD_TIME_FACTOR; >>> } >>>=20 >>> /** >>> @@ -241,7 +246,7 @@ public class SftpFileObject extends Abst >>> final ChannelSftp channel =3D fileSystem.getChannel(); >>> try >>> { >>> - int newMTime =3D (int) (modtime / 1000L); >>> + int newMTime =3D (int) (modtime / MOD_TIME_FACTOR); >>>=20 >>> attrs.setACMODTIME(attrs.getATime(), newMTime); >>> channel.setStat(relPath, attrs); >>> @@ -301,7 +306,8 @@ public class SftpFileObject extends Abst >>> protected FileObject[] doListChildrenResolved() throws Exception >>> { >>> // should not require a round-trip because type is already = set. >>> - if (this.isFile()) { >>> + if (this.isFile()) >>> + { >>> return null; >>> } >>> // List the contents of the folder >>>=20 >>> Modified: >> = commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provid= er/sftp/SftpFileSystem.java >>> URL: >> = http://svn.apache.org/viewvc/commons/proper/vfs/trunk/core/src/main/java/o= rg/apache/commons/vfs2/provider/sftp/SftpFileSystem.java?rev=3D1245166&r1=3D= 1245165&r2=3D1245166&view=3Ddiff >>>=20 >> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >>> --- >> = commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provid= er/sftp/SftpFileSystem.java >> (original) >>> +++ >> = commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provid= er/sftp/SftpFileSystem.java >> Thu Feb 16 20:38:04 2012 >>> @@ -45,6 +45,8 @@ public class SftpFileSystem >>> implements FileSystem >>> { >>>=20 >>> + private static final long LAST_MOD_TIME_ACCURACY =3D 1000L; >>> + >>> private Session session; >>> // private final JSch jSch; >>> private ChannelSftp idleChannel; >>> @@ -196,13 +198,13 @@ public class SftpFileSystem >>> } >>>=20 >>> /** >>> - * last mod time is only a int and in seconds, thus can be off = by >> 999. >>> + * Last mod time is only a int and in seconds, thus can be off = by >> 999. >>> * >>> * @return 1000 >>> */ >>> @Override >>> public double getLastModTimeAccuracy() >>> { >>> - return 1000L; >>> + return LAST_MOD_TIME_ACCURACY; >>> } >>> } >>>=20 >>> Modified: >> = commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provid= er/sftp/SftpFileSystemConfigBuilder.java >>> URL: >> = http://svn.apache.org/viewvc/commons/proper/vfs/trunk/core/src/main/java/o= rg/apache/commons/vfs2/provider/sftp/SftpFileSystemConfigBuilder.java?rev=3D= 1245166&r1=3D1245165&r2=3D1245166&view=3Ddiff >>>=20 >> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >>> --- >> = commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provid= er/sftp/SftpFileSystemConfigBuilder.java >> (original) >>> +++ >> = commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provid= er/sftp/SftpFileSystemConfigBuilder.java >> Thu Feb 16 20:38:04 2012 >>> @@ -96,7 +96,10 @@ public final class SftpFileSystemConfigB >>> return true; >>> } >>>=20 >>> - /** @since 2.0 */ >>> + /** >>> + * @return a hash code value for this object. >>> + * @since 2.0 >>> + */ >>> @Override >>> public int hashCode() >>> { >>>=20 >>> Modified: >> = commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provid= er/tar/TarFileSystem.java >>> URL: >> = http://svn.apache.org/viewvc/commons/proper/vfs/trunk/core/src/main/java/o= rg/apache/commons/vfs2/provider/tar/TarFileSystem.java?rev=3D1245166&r1=3D= 1245165&r2=3D1245166&view=3Ddiff >>>=20 >> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >>> --- >> = commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provid= er/tar/TarFileSystem.java >> (original) >>> +++ >> = commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provid= er/tar/TarFileSystem.java >> Thu Feb 16 20:38:04 2012 >>> @@ -48,6 +48,8 @@ import org.apache.commons.vfs2.provider. >>> */ >>> public class TarFileSystem extends AbstractFileSystem implements >> FileSystem >>> { >>> + private static final int DEFAULT_INDEX_SIZE =3D 100; >>> + >>> private static final Log LOG =3D >> LogFactory.getLog(TarFileSystem.class); >>>=20 >>> private final File file; >>> @@ -82,7 +84,7 @@ public class TarFileSystem extends Abstr >>> // Build the index >>> try >>> { >>> - List strongRef =3D new >> ArrayList(100); >>> + List strongRef =3D new >> ArrayList(DEFAULT_INDEX_SIZE); >>> TarArchiveEntry entry; >>> while ((entry =3D getTarFile().getNextTarEntry()) !=3D = null) >>> { >>>=20 >>> Modified: >> = commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/util/M= essages.java >>> URL: >> = http://svn.apache.org/viewvc/commons/proper/vfs/trunk/core/src/main/java/o= rg/apache/commons/vfs2/util/Messages.java?rev=3D1245166&r1=3D1245165&r2=3D= 1245166&view=3Ddiff >>>=20 >> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >>> --- >> = commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/util/M= essages.java >> (original) >>> +++ >> = commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/util/M= essages.java >> Thu Feb 16 20:38:04 2012 >>> @@ -32,9 +32,8 @@ public final class Messages >>> /** >>> * Map from message code to MessageFormat object for the message. >>> */ >>> - private static ConcurrentMap messages =3D >>> - new ConcurrentHashMap(); >>> - private static final ResourceBundle resources =3D new >> CombinedResources("org.apache.commons.vfs2.Resources"); >>> + private static ConcurrentMap MessageMap = =3D >> new ConcurrentHashMap(); >>> + private static final ResourceBundle RESOURCES =3D new >> CombinedResources("org.apache.commons.vfs2.Resources"); >>>=20 >>> private Messages() >>> { >>> @@ -53,7 +52,7 @@ public final class Messages >>>=20 >>> /** >>> * Formats a message. >>> - * >>> + * >>> * @param code >>> * The message code. >>> * @param param >>> @@ -100,15 +99,15 @@ public final class Messages >>> throws MissingResourceException >>> { >>> // Check if the message is cached >>> - MessageFormat msg =3D messages.get(code); >>> + MessageFormat msg =3D MessageMap.get(code); >>> if (msg !=3D null) >>> { >>> return msg; >>> } >>>=20 >>> - final String msgText =3D resources.getString(code); >>> + final String msgText =3D RESOURCES.getString(code); >>> msg =3D new MessageFormat(msgText); >>> - messages.putIfAbsent(code, msg); >>> - return messages.get(code); >>> + MessageMap.putIfAbsent(code, msg); >>> + return MessageMap.get(code); >>> } >>> } >>>=20 >>>=20 >>=20 >>=20 >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org >> For additional commands, e-mail: dev-help@commons.apache.org >>=20 >>=20 >=20 >=20 > --=20 > E-Mail: garydgregory@gmail.com | ggregory@apache.org > JUnit in Action, 2nd Ed: http://bit.ly/ECvg0 > Spring Batch in Action: http://bit.ly/bqpbCK > Blog: http://garygregory.wordpress.com > Home: http://garygregory.com/ > Tweet! http://twitter.com/GaryGregory --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org For additional commands, e-mail: dev-help@commons.apache.org