Return-Path: X-Original-To: apmail-commons-dev-archive@www.apache.org Delivered-To: apmail-commons-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 19C479F77 for ; Sat, 25 Feb 2012 15:01:15 +0000 (UTC) Received: (qmail 24077 invoked by uid 500); 25 Feb 2012 15:01:14 -0000 Delivered-To: apmail-commons-dev-archive@commons.apache.org Received: (qmail 23955 invoked by uid 500); 25 Feb 2012 15:01:14 -0000 Mailing-List: contact dev-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Commons Developers List" Delivered-To: mailing list dev@commons.apache.org Received: (qmail 23918 invoked by uid 99); 25 Feb 2012 15:01:14 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 25 Feb 2012 15:01:14 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: local policy) Received: from [209.85.212.43] (HELO mail-vw0-f43.google.com) (209.85.212.43) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 25 Feb 2012 15:01:08 +0000 Received: by vbbfq11 with SMTP id fq11so2007373vbb.30 for ; Sat, 25 Feb 2012 07:00:47 -0800 (PST) Received-SPF: pass (google.com: domain of jcarman@carmanconsulting.com designates 10.52.21.168 as permitted sender) client-ip=10.52.21.168; Authentication-Results: mr.google.com; spf=pass (google.com: domain of jcarman@carmanconsulting.com designates 10.52.21.168 as permitted sender) smtp.mail=jcarman@carmanconsulting.com Received: from mr.google.com ([10.52.21.168]) by 10.52.21.168 with SMTP id w8mr3484210vde.77.1330182047282 (num_hops = 1); Sat, 25 Feb 2012 07:00:47 -0800 (PST) Received: by 10.52.21.168 with SMTP id w8mr2773866vde.77.1330182047192; Sat, 25 Feb 2012 07:00:47 -0800 (PST) MIME-Version: 1.0 Sender: jcarman@carmanconsulting.com Received: by 10.220.2.129 with HTTP; Sat, 25 Feb 2012 07:00:27 -0800 (PST) In-Reply-To: References: From: James Carman Date: Sat, 25 Feb 2012 10:00:27 -0500 X-Google-Sender-Auth: lW0WcVRF6y2UAwUklW1CGjGdUsA Message-ID: Subject: Re: [lang] Java 6 now To: Commons Developers List Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Gm-Message-State: ALoCoQkS7YEdwjKwzR3ErmxMYV6iOAxQQ8mJ5mdl++Z3dmGqVs/q3moVhxQmw2BLslrdbi/nAFnT X-Virus-Checked: Checked by ClamAV on apache.org Gary, In this case, we're dealing with a veto to a code modification, which is allowed. Here's the information with respect to code modification vetoes (http://www.apache.org/foundation/voting.html#Veto): "A code-modification proposal may be stopped dead in its tracks by a -1 vote by a qualified voter. This constitutes a veto, and it cannot be overruled nor overridden by anyone. Vetos stand until and unless withdrawn by their casters. To prevent vetos from being used capriciously, they must be accompanied by a technical justification showing why the change is bad (opens a security exposure, negatively affects performance, etc. ). A veto without a justification is invalid and has no weight." Since there is a technical justification ("it's not necessary") provided with this veto, it stands until "sebb" withdraws it. That isn't to say that I agree with sebb's assessment, necessarily. I think we should drop Java 5 like a bad habit. We already have a bad reputation for living in the past. We need to be more forward-leaning. We can always support older versions on older JDKs if necessary (could be a YAGNI situation). If we do jump JDK versions, I'd say we should jump major version numbers (which others have disagreed with in the past). To me, version numbers are cheap (look at Firefox!). On Sat, Feb 25, 2012 at 9:32 AM, Gary Gregory wrot= e: > On Sat, Feb 25, 2012 at 9:19 AM, sebb wrote: > >> On 25 February 2012 14:05, Gary Gregory wrote: >> > Right now, in trunk, we have: >> > >> > Description =A0 =A0Resource =A0 =A0Path =A0 =A0Location =A0 =A0Type >> > The method getInstance(Locale) is undefined for the type >> > DateFormatSymbols =A0 =A0FastDateParser.java >> > /commons-lang/src/main/java/org/apache/commons/lang3/time =A0 =A0line = 352 >> > Java Problem >> > >> > Because we are using (still) some Java 6 code for this recent >> contribution. >> >> >> This one is trivial to fix: >> >> =A0 =A0 =A0 =A0 =A0 =A0DateFormatSymbols symbols=3D new DateFormatSymbol= s(locale); >> >> > Let's stop this Java 5 craziness in trunk and update to Java 6. >> > >> > Ready, set, ... go? >> >> -1 >> >> Completely unnecessary in this case. >> > > Really? IMO, this process is unnecessary: > > - A developer sees a feature/bug that needs attention and takes the time = to > develop it, test it and submit a patch using current technology, Java 6, > not even 7. > - The patch is rejected because it is a Java 6 patch > - A developer redoes the patch for Java 5 and the code is committed to tr= unk > - I find that the code is still not right for Java 5 and suggest we move = to > Java 6. > - A developer changes the code AGAIN for Java 5, finally getting it right= . > > This shows to me that we have created -- intentionally -- an impediment f= or > people to contribute to this project. > > Java 5 is dead and no one is forced to use a new version of this project > that requires Java 6. > > Gary > > >> > IMO, I do not think this requires a formal vote, but we can have one..= . >> > >> > Gary >> > >> > -- >> > E-Mail: garydgregory@gmail.com | ggregory@apache.org >> > JUnit in Action, 2nd Ed: http://bit.ly/ECvg0 >> > Spring Batch in Action: http://bit.ly/bqpbCK >> > Blog: http://garygregory.wordpress.com >> > Home: http://garygregory.com/ >> > Tweet! http://twitter.com/GaryGregory >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org >> For additional commands, e-mail: dev-help@commons.apache.org >> >> > > > -- > E-Mail: garydgregory@gmail.com | ggregory@apache.org > JUnit in Action, 2nd Ed: http://bit.ly/ECvg0 > Spring Batch in Action: http://bit.ly/bqpbCK > Blog: http://garygregory.wordpress.com > Home: http://garygregory.com/ > Tweet! http://twitter.com/GaryGregory --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org For additional commands, e-mail: dev-help@commons.apache.org