Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (athena.apache.org: domain of
 SRS0=uvdC=BB=m4x.org=sebastien.brisard@bounces.m4x.org designates
 129.104.30.34 as permitted sender)
Received-SPF: pass (google.com: domain of sebastien.brisard@m4x.org designates
 10.220.156.72 as permitted sender) client-ip=10.220.156.72;
MIME-Version: 1.0
In-Reply-To: <4F45E6F0.9020804@tue.nl>
References: <20120222230433.63AC4238889B@eris.apache.org>
	<4F45E6F0.9020804@tue.nl>
Date: Thu, 23 Feb 2012 09:25:48 +0100
Message-ID: 
 <CAGRH7HognzH285xh=vMTRTnL=BVDMoGmWguP8fyqse6sHuPtXw@mail.gmail.com>
Subject: Re: svn commit: r1292572 -
 /commons/proper/math/trunk/src/main/java/org/apache/commons/math3/distribution/TriangularDistribution.java
From: =?ISO-8859-1?Q?S=E9bastien_Brisard?= <sebastien.brisard@m4x.org>
To: Commons Developers List <dev@commons.apache.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Hi Dennis,
> Hi all,
>
> Now that I look at this code again, should we not attempt to avoid divide=
 by
> zero in case a =3D=3D b, in this method, and perhaps other methods of thi=
s
> class?
>
I think the constructor takes care of this special case.

>
> Also, looking that the Wikipedia article, at
> http://en.wikipedia.org/wiki/Triangular_distribution (which is referenced=
 in
> the javadoc of this class), "if (p <=3D (c - a) / (b - a))" should become=
 "if
> (p < (c - a) / (b - a)) " instead. Just to keep it consistent with the
> Wikipedia article...?
>
> Best regards,
> Dennis
>
I really have no opinion on this subject.
S=E9bastien


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org