Return-Path: X-Original-To: apmail-commons-dev-archive@www.apache.org Delivered-To: apmail-commons-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EBCD69666 for ; Thu, 9 Feb 2012 15:00:51 +0000 (UTC) Received: (qmail 43779 invoked by uid 500); 9 Feb 2012 15:00:51 -0000 Delivered-To: apmail-commons-dev-archive@commons.apache.org Received: (qmail 43647 invoked by uid 500); 9 Feb 2012 15:00:50 -0000 Mailing-List: contact dev-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Commons Developers List" Delivered-To: mailing list dev@commons.apache.org Received: (qmail 43638 invoked by uid 99); 9 Feb 2012 15:00:50 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Feb 2012 15:00:50 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: local policy) Received: from [193.74.71.27] (HELO eir.is.scarlet.be) (193.74.71.27) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Feb 2012 15:00:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=scarlet.be; s=scarlet; t=1328799622; bh=SXiHBk9/5UHlGwAsbynbn8u6HY/FqBnRRD6R5RlT/G8=; h=Date:From:To:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Transfer-Encoding:In-Reply-To; b=D73Ma+vUnfCkB85rQBClPcQ9MB92QqsoX2JJDbqAWTEZmQ53rsoLsrNeN6ot+PVXb /23cNJTfd0UpNf6j7Z7e5iPcmJkjYlJc2c15E1ww1wtKG5vjv0OH1pK9t6VmIHgVz3 I3zasllMvUAPm1kcmCbj/wJ2Xg6OlMEuLLt+22hY= Received: from mail.harfang.homelinux.org (ip-62-235-198-98.dsl.scarlet.be [62.235.198.98]) by eir.is.scarlet.be (8.14.5/8.14.5) with ESMTP id q19F0Lrt031020 for ; Thu, 9 Feb 2012 16:00:22 +0100 X-Scarlet: d=1328799622 c=62.235.198.98 Received: from localhost (mail.harfang.homelinux.org [192.168.20.11]) by mail.harfang.homelinux.org (Postfix) with ESMTP id C3B1961CEB for ; Thu, 9 Feb 2012 16:00:21 +0100 (CET) Received: from mail.harfang.homelinux.org ([192.168.20.11]) by localhost (mail.harfang.homelinux.org [192.168.20.11]) (amavisd-new, port 10024) with ESMTP id yBUS-kinrHN6 for ; Thu, 9 Feb 2012 16:00:15 +0100 (CET) Received: from dusk.harfang.homelinux.org (mail.harfang.homelinux.org [192.168.20.11]) by mail.harfang.homelinux.org (Postfix) with ESMTP id 5489561833 for ; Thu, 9 Feb 2012 16:00:15 +0100 (CET) Received: from eran by dusk.harfang.homelinux.org with local (Exim 4.77) (envelope-from ) id 1RvVTr-0007xm-90 for dev@commons.apache.org; Thu, 09 Feb 2012 16:00:15 +0100 Date: Thu, 9 Feb 2012 16:00:14 +0100 From: Gilles Sadowski To: dev@commons.apache.org Subject: Re: svn commit: r1242237 - in /commons/proper/math/trunk/src/main/java/org/apache/commons/math/filter: DefaultMeasurementModel.java DefaultProcessModel.java KalmanFilter.java MeasurementModel.java ProcessModel.java Message-ID: <20120209150014.GZ26355@dusk.harfang.homelinux.org> Mail-Followup-To: dev@commons.apache.org References: <20120209084255.6825C2388900@eris.apache.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Operating-System: Tiny Tux X-PGP-Key-Fingerprint: 53B9 972E C2E6 B93C BEAD 7092 09E6 AF46 51D0 5641 User-Agent: Mutt/1.5.21 (2010-09-15) X-DCC-scarlet.be-Metrics: eir 20002; Body=1 Fuz1=1 Fuz2=1 X-Virus-Scanned: clamav-milter 0.97.1-exp at eir X-Virus-Status: Clean On Thu, Feb 09, 2012 at 02:46:26PM +0000, sebb wrote: > 2012/2/9 S�bastien Brisard : > > 2012/2/9 sebb : > >> 2012/2/9 S�bastien Brisard : > >>> Hi, > >>> > >>>> > >>>> � �svn:keywords = Id > >>>> > >>>> Propchange: commons/proper/math/trunk/src/main/java/org/apache/commons/math/filter/DefaultProcessModel.java > >>>> ------------------------------------------------------------------------------ > >>>> � �svn:keywords = Id > >>>> > >>>> Propchange: commons/proper/math/trunk/src/main/java/org/apache/commons/math/filter/KalmanFilter.java > >>>> ------------------------------------------------------------------------------ > >>>> � �svn:keywords = Id > >>>> > >>>> Propchange: commons/proper/math/trunk/src/main/java/org/apache/commons/math/filter/MeasurementModel.java > >>>> ------------------------------------------------------------------------------ > >>>> � �svn:keywords = Id > >>>> > >>>> Propchange: commons/proper/math/trunk/src/main/java/org/apache/commons/math/filter/ProcessModel.java > >>>> ------------------------------------------------------------------------------ > >>>> � �svn:keywords = Id > >>>> > >>>> > >>> > >>> I think the property should read > >>> Author Date Id Revision > >> > >> Please don't use Date - it is locale-dependent and causes SVN tags to > >> disagree with source archives. > >> > >> Also @Author tags are strongly discouraged. > >> We �use changes.xml and contributors in the POM instead. > >> > > OK, my mistake. > > I was conforming with what I saw in existing files. So should the > > svn:keywords property read "Id", or "Id Revision"? > > Both Id and Revision are fine, and can both be useful. > > There's no harm in having the keywords set - it's only a problem if > they are *used*. > But having them set might encourage their use. I think that we decided to stick with $Id$ only since it also contains the revision number. Regards, Gilles --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org For additional commands, e-mail: dev-help@commons.apache.org