commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: svn commit: r1240761 - in /commons/proper/sanselan/trunk/src/main/java/org/apache/commons/sanselan: formats/jpeg/ icc/
Date Mon, 06 Feb 2012 14:45:26 GMT
On 5 February 2012 16:22,  <damjan@apache.org> wrote:
> Author: damjan
> Date: Sun Feb  5 16:22:25 2012
> New Revision: 1240761
>
> URL: http://svn.apache.org/viewvc?rev=1240761&view=rev
> Log:
> Hid formats.jpeg.JpegImageParser.AcceptedExtensions
> and converted icc classes to enums.
>
> Jira issue key: SANSELAN-42
>
>
> Added:
>    commons/proper/sanselan/trunk/src/main/java/org/apache/commons/sanselan/icc/IccTagDataTypes.java
  (with props)
>    commons/proper/sanselan/trunk/src/main/java/org/apache/commons/sanselan/icc/IccTagTypes.java
  (with props)
> Modified:
>    commons/proper/sanselan/trunk/src/main/java/org/apache/commons/sanselan/formats/jpeg/JpegImageParser.java
>    commons/proper/sanselan/trunk/src/main/java/org/apache/commons/sanselan/icc/IccConstants.java
>    commons/proper/sanselan/trunk/src/main/java/org/apache/commons/sanselan/icc/IccProfileParser.java
>    commons/proper/sanselan/trunk/src/main/java/org/apache/commons/sanselan/icc/IccTag.java
>    commons/proper/sanselan/trunk/src/main/java/org/apache/commons/sanselan/icc/IccTagDataType.java
>    commons/proper/sanselan/trunk/src/main/java/org/apache/commons/sanselan/icc/IccTagType.java
>
> Modified: commons/proper/sanselan/trunk/src/main/java/org/apache/commons/sanselan/formats/jpeg/JpegImageParser.java
> URL: http://svn.apache.org/viewvc/commons/proper/sanselan/trunk/src/main/java/org/apache/commons/sanselan/formats/jpeg/JpegImageParser.java?rev=1240761&r1=1240760&r2=1240761&view=diff
> ==============================================================================
> --- commons/proper/sanselan/trunk/src/main/java/org/apache/commons/sanselan/formats/jpeg/JpegImageParser.java
(original)
> +++ commons/proper/sanselan/trunk/src/main/java/org/apache/commons/sanselan/formats/jpeg/JpegImageParser.java
Sun Feb  5 16:22:25 2012
> @@ -82,11 +82,11 @@ public class JpegImageParser extends Ima
>
>     private static final String DEFAULT_EXTENSION = ".jpg";
>
> -    public static final String AcceptedExtensions[] = { ".jpg", ".jpeg", };
> +    private static final String ACCEPTED_EXTENSIONS[] = { ".jpg", ".jpeg", };
>
>     protected String[] getAcceptedExtensions()
>     {
> -        return AcceptedExtensions;
> +        return ACCEPTED_EXTENSIONS;
>     }

That still leaves the array entries open to modification by subclasses.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message