commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: svn commit: r1242237 - in /commons/proper/math/trunk/src/main/java/org/apache/commons/math/filter: DefaultMeasurementModel.java DefaultProcessModel.java KalmanFilter.java MeasurementModel.java ProcessModel.java
Date Thu, 09 Feb 2012 15:33:37 GMT
On 9 February 2012 15:00, Gilles Sadowski <gilles@harfang.homelinux.org> wrote:
> On Thu, Feb 09, 2012 at 02:46:26PM +0000, sebb wrote:
>> 2012/2/9 Sébastien Brisard <sebastien.brisard@m4x.org>:
>> > 2012/2/9 sebb <sebbaz@gmail.com>:
>> >> 2012/2/9 Sébastien Brisard <sebastien.brisard@m4x.org>:
>> >>> Hi,
>> >>>
>> >>>>
>> >>>>    svn:keywords = Id
>> >>>>
>> >>>> Propchange: commons/proper/math/trunk/src/main/java/org/apache/commons/math/filter/DefaultProcessModel.java
>> >>>> ------------------------------------------------------------------------------
>> >>>>    svn:keywords = Id
>> >>>>
>> >>>> Propchange: commons/proper/math/trunk/src/main/java/org/apache/commons/math/filter/KalmanFilter.java
>> >>>> ------------------------------------------------------------------------------
>> >>>>    svn:keywords = Id
>> >>>>
>> >>>> Propchange: commons/proper/math/trunk/src/main/java/org/apache/commons/math/filter/MeasurementModel.java
>> >>>> ------------------------------------------------------------------------------
>> >>>>    svn:keywords = Id
>> >>>>
>> >>>> Propchange: commons/proper/math/trunk/src/main/java/org/apache/commons/math/filter/ProcessModel.java
>> >>>> ------------------------------------------------------------------------------
>> >>>>    svn:keywords = Id
>> >>>>
>> >>>>
>> >>>
>> >>> I think the property should read
>> >>> Author Date Id Revision
>> >>
>> >> Please don't use Date - it is locale-dependent and causes SVN tags to
>> >> disagree with source archives.
>> >>
>> >> Also @Author tags are strongly discouraged.
>> >> We  use changes.xml and contributors in the POM instead.
>> >>
>> > OK, my mistake.
>> > I was conforming with what I saw in existing files. So should the
>> > svn:keywords property read "Id", or "Id Revision"?
>>
>> Both Id and Revision are fine, and can both be useful.
>>
>> There's no harm in having the keywords set - it's only a problem if
>> they are *used*.
>> But having them set might encourage their use.
>
> I think that we decided to stick with $Id$ only since it also contains the
> revision number.

It does, but sometimes (often ?) the revision number will be sufficient.

What's important is to avoid the properties that cause problems.
$Date is bad because it is locale-dependent; $Id offers a way round this.

> Regards,
> Gilles
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message