commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gary Gregory <garydgreg...@gmail.com>
Subject Re: [DISCUSS][POOL] Logging options for Pool2
Date Fri, 17 Feb 2012 21:13:18 GMT
So... are we ready to move some bits?
;)
Gary

On Sun, Feb 12, 2012 at 8:03 PM, Konstantin Kolinko
<knst.kolinko@gmail.com>wrote:

> 2012/2/13 Mark Thomas <markt@apache.org>:
> >
> > General
> > - Logging in pool, if any, should be minimal
> >
>
> Two general questions:
> When there are several pools,
> - is it possible to discern log messages from different pools?
> - is it possible to control logging level for a single pool, or all
> pools have the same logging configuration? E.g. to enable debug
> logging for a single pool only (if debug logging is ever implemented
> there).
>
> >
> > What do folks think to the following solution:
> > - make logging of factory exceptions a factory responsibility - clearly
> > documented in the JavaDoc for POOL2
> > - add some JMX stats to POOL2 for number of destroy / passivate /
> > activate exceptions
> > - make the last n (10?) exceptions of each type accessible via JMX for
> POOL2
> > ?
> >
>
> Overall this proposal looks good, but there is known caveat with
> keeping Exception instances in memory:  Their stacktrace data is known
> to pin classloaders in memory, preventing them from being garbage
> collected and thus causing PermGen memory leaks in web applications.
>
> This problem was reproduced in this Tomcat issue:
> https://issues.apache.org/bugzilla/show_bug.cgi?id=50460
> Discussion:
> http://marc.info/?l=tomcat-dev&m=129211856426188&w=2
>
> A workaround might be to print stacktraces as strings and keep the
> strings in memory, but it may be time-consuming. The good point though
> is that the time to print those exceptions to strings is comparable
> with the one spent when printing them to a log file.
>
> Best regards,
> Konstantin Kolinko
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>


-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message