commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Konstantin Kolinko <knst.koli...@gmail.com>
Subject Re: svn commit: r1242237 - in /commons/proper/math/trunk/src/main/java/org/apache/commons/math/filter: DefaultMeasurementModel.java DefaultProcessModel.java KalmanFilter.java MeasurementModel.java ProcessModel.java
Date Thu, 09 Feb 2012 17:31:11 GMT
2012/2/9 sebb <sebbaz@gmail.com>:
> On 9 February 2012 16:01, Thomas Neidhart <thomas.neidhart@gmail.com> wrote:
>> On 02/09/2012 03:46 PM, sebb wrote:
>>
>>> Both Id and Revision are fine, and can both be useful.
>>>
>>> There's no harm in having the keywords set - it's only a problem if
>>> they are *used*.
>>> But having them set might encourage their use.
>>
>> Ok, makes sense to not set the other keywords just in case. Btw.
>>
>> Actually, I have taken the default settings from here:
>>
>> http://wiki.apache.org/commons/UsingSVN
>
> Did not know about that; fixed.
>

Note that there exists official
http://www.apache.org/dev/svn-eol-style.txt

>> Maybe we should add a section in the developers guide for the math
>> component:
>>
>> http://commons.apache.org/math/developers.html
>
> Or update the Commons guidelines (if any)?
>
>> A short statistic on the source files in src/main/java:
>>
>>     61 "Author Date Id Revision"
>
> That's a bug - the quotes will be treated as part of the keyword, so
> (e.g.) Revision won't work.
>
>>    429 Author Date Id Revision
>>      2 Date Revision
>>      7 Date Revision Id
>>
>> 121 file do not have keywords set yet.


>From practical point of view (I cannot say anything about policies)
the svn:keywords property is needed only if those keywords are
actually used in those files.

The "Author Date Id Revision" value (without quotes) should have
brought in by CVS->SVN migration.

Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message