commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Simone Tripodi <simonetrip...@apache.org>
Subject Re: [Graph] Possible NPE if user requests a vertex that not exists on BaseGraph class
Date Wed, 15 Feb 2012 19:57:55 GMT
Hola!

I'd recommend to throw the GraphException, as we reported in the javadoc:

     * <b>NOTE</b>: implementors have to take in consideration
throwing a {@link GraphException}
     * if an error occurs while performing that operation.

How does it sound?
all the best,

-Simo

http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/



On Wed, Feb 15, 2012 at 7:25 PM, Marco Speranza
<marcosperanza@apache.org> wrote:
> Hi all guys,
>
> I notice that the methods "getConnectedVertices( V v )" and "getEdge( V
> source, V target )" into the class BaseGraph are not protect if a user
> passes  a vertex that not exists.
> Moreover in the first case the system throws a NPE and in the second case
> the system accepts the argument but return a null value to the user.
>
> Should it be a good idea put a control and throw a IllegalArgumentEx in
> both cases?
> WDYT?
>
> Ciao
>
> --
> Marco Speranza <marcosperanza@ <marco.speranza79@gmail.com>apache.org>
> Google Code: http://code.google.com/u/marco.speranza79/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message