commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Thomas Neidhart <thomas.neidh...@gmail.com>
Subject Re: [math] Merge of interface and implementation of *Test classes in stat.inference
Date Thu, 09 Feb 2012 18:43:54 GMT
> On Fri, Feb 03, 2012 at 08:33:44PM +0100, Thomas Neidhart wrote:
>> Hi,
>>
>> I have been working on the exceptions in the stat.inference package and
>> have seen that all classes in this package follow the same scheme:
>>
>>  - Interface for a statistical test
>>  - Implementation of this single interface

Hi,

I have started to work on this issue (see MATH-739).

For the ChiSquareTest I have a question though:

The test was split up into two interfaces:

 - ChiSquareTest
 - UnknownDistributionChiSquareTest

with one class implementing both (ChiSquareTestImpl).

When merging interface and implementation this subtle difference would
get lost. When looking at the T-Test, it contains also methods for
different tests:

 - one-/two-sample
 - one-/two-sided
 - paired/unpaired
 - homoscedastic/heteroscedastic

so imo it should be fine to do the same for the Chi-square test.

What do you think?

@Exceptions: while working on the migration to the new exceptions in
this package, I tried to stick to the rules from Phil/Luc:

 - add @throws clause to javadoc
 - add throws declaration to method signature

for each individual exception that can be thrown.

This can lead to pretty elaborate signatures, see f.e.
WilcoxonSignedRankTest#wilcoxonSignedRankTest(double[], double[], boolean)

Is it ok like that?

Thomas

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message