commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilles Sadowski <gil...@harfang.homelinux.org>
Subject Re: svn commit: r1292572 - /commons/proper/math/trunk/src/main/java/org/apache/commons/math3/distribution/TriangularDistribution.java
Date Thu, 23 Feb 2012 11:27:30 GMT
On Thu, Feb 23, 2012 at 08:12:48AM +0100, Dennis Hendriks wrote:
> Hi all,
> 
> Now that I look at this code again, should we not attempt to avoid
> divide by zero in case a == b, in this method, and perhaps other
> methods of this class?
> 
> Also, looking that the Wikipedia article, at
> http://en.wikipedia.org/wiki/Triangular_distribution (which is
> referenced in the javadoc of this class), "if (p <= (c - a) / (b -
> a))" should become "if (p < (c - a) / (b - a)) " instead. Just to
> keep it consistent with the Wikipedia article...?

Done in revision 1292741.

Gilles

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message