Return-Path: 
 <dev-return-132725-apmail-commons-dev-archive=commons.apache.org@commons.apache.org>
X-Original-To: apmail-commons-dev-archive@www.apache.org
Delivered-To: apmail-commons-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 47775BF3E
	for <apmail-commons-dev-archive@www.apache.org>;
 Sun, 22 Jan 2012 22:32:18 +0000 (UTC)
Received: (qmail 70318 invoked by uid 500); 22 Jan 2012 22:32:17 -0000
Delivered-To: apmail-commons-dev-archive@commons.apache.org
Received: (qmail 70227 invoked by uid 500); 22 Jan 2012 22:32:16 -0000
Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@commons.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@commons.apache.org>
List-Post: <mailto:dev@commons.apache.org>
List-Id: <dev.commons.apache.org>
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Delivered-To: mailing list dev@commons.apache.org
Received: (qmail 70219 invoked by uid 99); 22 Jan 2012 22:32:16 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 22 Jan 2012 22:32:16 +0000
X-ASF-Spam-Status: No, hits=-0.0 required=5.0
	tests=SPF_PASS
X-Spam-Check-By: apache.org
Received-SPF: pass (athena.apache.org: local policy)
Received: from [85.13.144.143] (HELO dd25322.kasserver.com) (85.13.144.143)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 22 Jan 2012 22:32:10 +0000
Received: from [192.168.2.101] (dslb-094-220-112-044.pools.arcor-ip.net
 [94.220.112.44])
	by dd25322.kasserver.com (Postfix) with ESMTPSA id 225201DFA067
	for <dev@commons.apache.org>; Sun, 22 Jan 2012 23:31:49 +0100 (CET)
Message-ID: <4F1C8E55.5010609@systemoutprintln.de>
Date: Sun, 22 Jan 2012 23:31:49 +0100
From: Benedikt Ritter <bene@systemoutprintln.de>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:9.0) Gecko/20111222 Thunderbird/9.0.1
MIME-Version: 1.0
To: dev@commons.apache.org
Subject: Re: [jira] [Resolved] (SANDBOX-363) Check if value is of the correct
 type in Argument.argument( Class<T> type, V value )
References: 
 <1224838850.65030.1327267960008.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1224838850.65030.1327267960008.JavaMail.tomcat@hel.zones.apache.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Am 22.01.2012 22:32, schrieb Simone Tripodi (Resolved) (JIRA):
>
>       [ https://issues.apache.org/jira/browse/SANDBOX-363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Simone Tripodi resolved SANDBOX-363.
> ------------------------------------
>
>      Resolution: Fixed
>        Assignee: Simone Tripodi
>
> patch applied, see [r1234616|https://svn.apache.org/viewvc?view=revision&revision=1234616]
>
> as a side note: {{Argument.getParameterTypes}} is an internal method, I moved the checks in the higher level, as soon as arguments need to be checked, because invoked in constructors or methods.

getParameterTypes has default visibility and for that reason can be used 
by other classes (for example BeanAccessor ;-). So I wouldn't exactly 
call it an internal method. Wouldn't it be better to leave the check in 
there?

>
> Thanks for contributing! ;)
>
>> Check if value is of the correct type in Argument.argument( Class<T>  type, V value )
>> ------------------------------------------------------------------------------------
>>
>>                  Key: SANDBOX-363
>>                  URL: https://issues.apache.org/jira/browse/SANDBOX-363
>>              Project: Commons Sandbox
>>           Issue Type: Improvement
>>           Components: BeanUtils2
>>     Affects Versions: Nightly Builds
>>             Reporter: Benedikt Ritter
>>             Assignee: Simone Tripodi
>>             Priority: Minor
>>          Attachments: SANDBOX-363.txt, SANDBOX-363v2.txt
>>
>>
>> Although the compiler should check that value is always of the correct type, a programmatic check should back this up.
>
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org