commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Niall Pemberton <niall.pember...@gmail.com>
Subject Re: [VOTE] Release Apache Commons Validator 1.4.0 based on RC1
Date Sat, 28 Jan 2012 21:12:16 GMT
On Sat, Jan 28, 2012 at 5:53 PM, Nick Burch <nick.burch@alfresco.com> wrote:
> On Sat, 28 Jan 2012, Oliver Heger wrote:
>>
>> I had problems with the ant build, there were compilation errors. I am not
>> sure whether I have to define the paths to dependent libraries in
>> build.properties. This is not mentioned in the building instructions, and
>> build.xml tries to download some libraries. Probably not blocking, but I
>> think build.xml should be kept up to date or removed at all.
>
>
> It looks like ibiblio have changed the URL for some of the dependencies.
> I've updated them in r1237106, and the ant build now works fine for me
>
>
>> The clirr report gives two errors. One is mentioned in the release notes,
>> and I think this is okay. I don't know about the other one, especially as
>> the release notes say there are no breaking changes. Can you comment on
>> this?
>
>
> I've no idea on this. It's not in an area of the code I've ever worked on,
> and it's in the old style of Validation that's now mostly deprecated. The
> change is in a constructor of a protected inner class, which I think is only
> used internally (the only reference in the codebase is within the parent
> class). So, my hunch is that this isn't a problem

The problem was introduced 3 weeks ago in r1227700 when ResultStatus
was changed from being an inner class to a static inner class.

http://svn.apache.org/viewvc?view=revision&revision=1227700

This change should be reverted and doing so resolves the clirr error.

Niall

> Nick
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message