commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: [VOTE] Release Commons Pool 1.6-RC2
Date Wed, 04 Jan 2012 13:30:35 GMT
On 4 January 2012 13:10, sebb <sebbaz@gmail.com> wrote:
> On 31 December 2011 19:21, Gary Gregory <ggregory@apache.org> wrote:
>> Good day to you all:
>>
>> I have prepared Commons Pool 1.6-RC2.
>>
>> The changes from RC1 are to fix: \
>>
>> - Relase notes txt are for 1.6, not 1.5.7.
>> - Adjust copyright to 2012 from 2011.
>> - Bin distro does not include SNAPSHOT files.
>>
>> The only changes from 1.5.7 are the additions of generics and therefore
>> requires Java 5.
>>
>> Tag:
>>
>> https://svn.apache.org/repos/asf/commons/proper/pool/tags/POOL_1_6_RC2/
>>
>> Site:
>>
>> https://people.apache.org/builds/commons/pool/1.6/RC2/
>>
>> Binaries:
>>
>> https://repository.apache.org/content/repositories/orgapachecommons-006/
>>
>> The link above includes checksum files.
>>
>> [ ] +1 release it
>> [ ] +0 almost, please fix:
>> [X] -1 no because:
>
> I think the tag needs to be checked against the source archive before
> release, because the tag commit message looks odd (see other e-mail)
>
> I'll do that shortly, and will withdraw the -1 if all is OK.

The source archive does NOT agree fully with the tag.

For example,

Tag: <!-- $Id: build.xml 1226175 2011-12-31 18:59:42Z ggregory $ -->
Src: <!-- $Id: build.xml 1226157 2011-12-31 18:21:39Z ggregory $ -->

There are several other files that don't agree, so clearly the source
was not created from a clean checkout of the tag.

I think this is a blocker.

BTW, several files use the $Date SVN tag, which also causes
differences (I've excluded them in the comparison).

Ideally those should be removed.

>> This VOTE is open for at least 72 hours (holidays, hangovers, and all),
>> until Janurary 1 2011, 23:00 EST.
>>
>> Changes:
>> o [POOL-208] Support Java 1.5 Generics in version 1.x.
>>
>> Thank you and happy new year,
>> Gary
>>
>> --
>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>> JUnit in Action, 2nd Ed: http://bit.ly/ECvg0
>> Spring Batch in Action: http://bit.ly/bqpbCK
>> Blog: http://garygregory.wordpress.com
>> Home: http://garygregory.com/
>> Tweet! http://twitter.com/GaryGregory <http://twitter.com/GaryGregory>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message