commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: svn commit: r1226175 - in /commons/proper/pool/tags/POOL_1_6_RC2: ./ src/changes/ src/java/org/apache/commons/pool/ src/java/org/apache/commons/pool/impl/ src/site/ src/site/xdoc/ src/test/org/apache/commons/pool/
Date Wed, 04 Jan 2012 14:33:09 GMT
On 4 January 2012 14:24, Gary Gregory <garydgregory@gmail.com> wrote:
> On Wed, Jan 4, 2012 at 8:26 AM, sebb <sebbaz@gmail.com> wrote:
>
>> On 4 January 2012 12:58, Gary Gregory <garydgregory@gmail.com> wrote:
>> > On Tue, Jan 3, 2012 at 6:13 PM, sebb <sebbaz@gmail.com> wrote:
>> >
>> >> On 31 December 2011 18:59,  <ggregory@apache.org> wrote:
>> >> > Author: ggregory
>> >> > Date: Sat Dec 31 18:59:42 2011
>> >> > New Revision: 1226175
>> >> >
>> >> > URL: http://svn.apache.org/viewvc?rev=1226175&view=rev
>> >> > Log:
>> >> > Create commons-pool-1.6-RC2 tag
>> >>
>> >> What command did you use to create the tag?
>> >>
>> >
>> > svn copy . -m"Create commons-pool-1.6-RC2 tag"
>> > https://svn.apache.org/repos/asf/commons/proper/pool/tags/POOL_1_6_RC2
>>
>> And how did you create the workspace?
>>
>> >
>> >> The commit message is rather confusing, as it references multiple
>> >> revisions.
>> >>
>> >
>> > It does?
>>
>> <quote>
>> commons/proper/pool/tags/POOL_1_6_RC2/
>>     - copied from r1222662, commons/proper/pool/branches/POOL_1_X/
>>   commons/proper/pool/tags/POOL_1_6_RC2/NOTICE.txt
>>     - copied unchanged from r1226157,
>> commons/proper/pool/branches/POOL_1_X/NOTICE.txt
>>   commons/proper/pool/tags/POOL_1_6_RC2/RELEASE-NOTES.txt
>>     - copied unchanged from r1226155,
>> commons/proper/pool/branches/POOL_1_X/RELEASE-NOTES.txt
>> </quote>
>>
>> This (partial) extract references r1222662 r1226157 r1226155
>>
>
> SVN continues to confuse me, I thought SVN revisioned trees, not individual
> files?
>
>
>>
>> > The log in this email shows "Create commons-pool-1.6-RC2 tag"
>> > which matches the command above. Now, I'm confused too ;)
>> >
>> >>
>> >> Did you run svn update before committing?
>> >>
>> >
>> > I can't recall doing so.
>>
>> That could explain it.
>>
>
> That does not make sense to me because I'm the one who did the last few
> commits. It matters as you point out.
>
>
>>
>> > When I checkout the tag, everything seems OK, I can do an "m3 test".
>>
>> That does not prove much.
>>
>> The tag itself hopefully corresponds with the source archive - did you
>> do a fresh checkout of the tag and build from that?
>>
>
> Arg! I did a build from my normal workspace. I guess I do not understand
> how an up-to-date workspace can be different from what the tag creates.

For a start, a random workspace can contain unversioned files. If
these are ignored, they won't show up.

> Questions:
>
> Is the tag wrong or is the build wrong?

Both, I think.

> Can a new RC be avoided by creating the tag correctly from what I have?

No, I don't think so.

> By the time I get all the build step rights every time I RC with SVN, we'll
> be on git by then! ;)
>
> Gary
>
>>
>> > Gary
>> >
>> >
>> >>
>> >> > Added:
>> >> >    commons/proper/pool/tags/POOL_1_6_RC2/
>> >> >      - copied from r1222662, commons/proper/pool/branches/POOL_1_X/
>> >> >    commons/proper/pool/tags/POOL_1_6_RC2/NOTICE.txt
>> >> >      - copied unchanged from r1226157,
>> >> commons/proper/pool/branches/POOL_1_X/NOTICE.txt
>> >> >    commons/proper/pool/tags/POOL_1_6_RC2/RELEASE-NOTES.txt
>> >> >      - copied unchanged from r1226155,
>> >> commons/proper/pool/branches/POOL_1_X/RELEASE-NOTES.txt
>> >> >    commons/proper/pool/tags/POOL_1_6_RC2/build.xml
>> >> >      - copied unchanged from r1226157,
>> >> commons/proper/pool/branches/POOL_1_X/build.xml
>> >> >    commons/proper/pool/tags/POOL_1_6_RC2/doap_pool.rdf
>> >> >      - copied unchanged from r1226156,
>> >> commons/proper/pool/branches/POOL_1_X/doap_pool.rdf
>> >> >    commons/proper/pool/tags/POOL_1_6_RC2/pom.xml
>> >> >      - copied, changed from r1225736,
>> >> commons/proper/pool/branches/POOL_1_X/pom.xml
>> >> >    commons/proper/pool/tags/POOL_1_6_RC2/src/changes/changes.xml
>> >> >      - copied unchanged from r1226172,
>> >> commons/proper/pool/branches/POOL_1_X/src/changes/changes.xml
>> >> >
>> >>
>>  commons/proper/pool/tags/POOL_1_6_RC2/src/java/org/apache/commons/pool/PoolUtils.java
>> >> >      - copied unchanged from r1222670,
>> >>
>> commons/proper/pool/branches/POOL_1_X/src/java/org/apache/commons/pool/PoolUtils.java
>> >> >
>> >>
>>  commons/proper/pool/tags/POOL_1_6_RC2/src/java/org/apache/commons/pool/impl/CursorableLinkedList.java
>> >> >      - copied unchanged from r1222710,
>> >>
>> commons/proper/pool/branches/POOL_1_X/src/java/org/apache/commons/pool/impl/CursorableLinkedList.java
>> >> >
>> >>
>>  commons/proper/pool/tags/POOL_1_6_RC2/src/java/org/apache/commons/pool/impl/SoftReferenceObjectPool.java
>> >> >      - copied unchanged from r1222710,
>> >>
>> commons/proper/pool/branches/POOL_1_X/src/java/org/apache/commons/pool/impl/SoftReferenceObjectPool.java
>> >> >
>> >>
>>  commons/proper/pool/tags/POOL_1_6_RC2/src/java/org/apache/commons/pool/impl/StackKeyedObjectPool.java
>> >> >      - copied unchanged from r1222710,
>> >>
>> commons/proper/pool/branches/POOL_1_X/src/java/org/apache/commons/pool/impl/StackKeyedObjectPool.java
>> >> >    commons/proper/pool/tags/POOL_1_6_RC2/src/site/site.xml
>> >> >      - copied unchanged from r1222672,
>> >> commons/proper/pool/branches/POOL_1_X/src/site/site.xml
>> >> >
>>  commons/proper/pool/tags/POOL_1_6_RC2/src/site/xdoc/download_pool.xml
>> >> >      - copied unchanged from r1222897,
>> >> commons/proper/pool/branches/POOL_1_X/src/site/xdoc/download_pool.xml
>> >> >    commons/proper/pool/tags/POOL_1_6_RC2/src/site/xdoc/downloads.xml
>> >> >      - copied unchanged from r1222677,
>> >> commons/proper/pool/branches/POOL_1_X/src/site/xdoc/downloads.xml
>> >> >
>> >>
>>  commons/proper/pool/tags/POOL_1_6_RC2/src/test/org/apache/commons/pool/MethodCall.java
>> >> >      - copied unchanged from r1222710,
>> >>
>> commons/proper/pool/branches/POOL_1_X/src/test/org/apache/commons/pool/MethodCall.java
>> >> >
>> >>
>>  commons/proper/pool/tags/POOL_1_6_RC2/src/test/org/apache/commons/pool/MethodCallPoolableObjectFactory.java
>> >> >      - copied unchanged from r1222710,
>> >>
>> commons/proper/pool/branches/POOL_1_X/src/test/org/apache/commons/pool/MethodCallPoolableObjectFactory.java
>> >> >
>> >>
>>  commons/proper/pool/tags/POOL_1_6_RC2/src/test/org/apache/commons/pool/TestKeyedObjectPool.java
>> >> >      - copied unchanged from r1222710,
>> >>
>> commons/proper/pool/branches/POOL_1_X/src/test/org/apache/commons/pool/TestKeyedObjectPool.java
>> >> >
>> >>
>>  commons/proper/pool/tags/POOL_1_6_RC2/src/test/org/apache/commons/pool/TestObjectPool.java
>> >> >      - copied unchanged from r1222710,
>> >>
>> commons/proper/pool/branches/POOL_1_X/src/test/org/apache/commons/pool/TestObjectPool.java
>> >> >
>> >>
>>  commons/proper/pool/tags/POOL_1_6_RC2/src/test/org/apache/commons/pool/WaiterFactory.java
>> >> >      - copied unchanged from r1222710,
>> >>
>> commons/proper/pool/branches/POOL_1_X/src/test/org/apache/commons/pool/WaiterFactory.java
>> >> >
>> >> > Copied: commons/proper/pool/tags/POOL_1_6_RC2/pom.xml (from r1225736,
>> >> commons/proper/pool/branches/POOL_1_X/pom.xml)
>> >> > URL:
>> >>
>> http://svn.apache.org/viewvc/commons/proper/pool/tags/POOL_1_6_RC2/pom.xml?p2=commons/proper/pool/tags/POOL_1_6_RC2/pom.xml&p1=commons/proper/pool/branches/POOL_1_X/pom.xml&r1=1225736&r2=1226175&rev=1226175&view=diff
>> >> >
>> >>
>> ==============================================================================
>> >> > --- commons/proper/pool/branches/POOL_1_X/pom.xml (original)
>> >> > +++ commons/proper/pool/tags/POOL_1_6_RC2/pom.xml Sat Dec 31 18:59:42
>> >> 2011
>> >> > @@ -27,7 +27,7 @@
>> >> >   <modelVersion>4.0.0</modelVersion>
>> >> >   <groupId>commons-pool</groupId>
>> >> >   <artifactId>commons-pool</artifactId>
>> >> > -  <version>1.6-SNAPSHOT</version>
>> >> > +  <version>1.6</version>
>> >> >   <name>Commons Pool</name>
>> >> >
>> >> >   <inceptionYear>2001</inceptionYear>
>> >> >
>> >> >
>> >>
>> >> ---------------------------------------------------------------------
>> >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> >> For additional commands, e-mail: dev-help@commons.apache.org
>> >>
>> >>
>> >
>> >
>> > --
>> > E-Mail: garydgregory@gmail.com | ggregory@apache.org
>> > JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
>> > Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
>> > Blog: http://garygregory.wordpress.com
>> > Home: http://garygregory.com/
>> > Tweet! http://twitter.com/GaryGregory
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
> Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message