commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From S├ębastien Brisard <>
Subject Re: svn commit: r1230906 - in /commons/proper/math/trunk/src/main/java/org/apache/commons/math/random:
Date Sat, 14 Jan 2012 16:50:58 GMT

> I used to do that when we still had a single root hierarchy. Changing
> the root temporarily to checked was a simple and efficient way to make
> sure javadoc was OK.
> Now we have removed the single root and this has become a nightmare to
> maintain as every single exception has to be temporarily changed to
> checked in order to do this bookkeeping. This is impossible to do.
> As Throwable, Exception and RuntimeException are all classes and not
> interfaces, we can even not declare some intermediate MathThrowable
> interface that would extend RuntimeException in production distribution
> and could be changed to extend Exception in developers works spaces to
> ensure javadoc and throws statements are up to date. I sincerely regret
> this.
> Luc
what I did in r1230906 was
1. make sure that exceptions actually thrown in RandomDataImpl are
identical with the @throws clause in the Javadoc of RandomData.
2. add the unchecked exceptions to the methods signatures.

>From what I understand, all exceptions should remain in the javadoc,
right? As for methods signatures, I should probably get rid of the
throws in the interface RandomData. How about RandomDataImpl? Would
you rather have the exceptions in the method signature, or not?

Thanks for your advice, and I promise I'll clean up my mess ASAP.


To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message