commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gary Gregory <garydgreg...@gmail.com>
Subject Re: [VOTE] Release Apache Commons Validator 1.4.0 Based on RC
Date Mon, 30 Jan 2012 18:18:18 GMT
-0:

The text in RELEASE-NOTES.txt contradicts itself:

First we say:
"
IMPORTANT NOTES
================

BREAKING CHANGES:

 * NONE.
"

Then at the end we say:

"
OTHER NOTES
============

Users should be aware of the following potential issues with migration:

 * The protected method validator.EmailValidator.isValidIpAddress()
previously
   exposed a Jakarta ORO class via its signature.  The signature has been
   modified to accept a a java.lang.String and is not therefore not
compatible.
   However, this class is deprecated and clients should use the equivalent
   class in the validator.routines package.

* Invocations of the method GenericValidator.matchRegexp() should be
inspected
  for semantic differences between Jakarta ORO and Java regular expressions.
"

The release is therefore binary incompatible (a "BREAKING" change) for the
first reason and semantically incompatible for the second (a different kind
of "BREAKING" change). This should be filed under "IMPORTANT" IMO, not an
"OTHER" note.

Not blockers, but should be fixed (easy):

Checkstyle: 4 x "Expected @param tag for ..."

Then these are unknown as to blockers: 2 findbugs issues:

Inconsistent synchronization of
org.apache.commons.validator.ValidatorAction.jsFunction; locked 62% of time
MT_CORRECTNESSIS2_INCONSISTENT_SYNC<http://findbugs.sourceforge.net/bugDescriptions.html#IS2_INCONSISTENT_SYNC>
348MediumClass org.apache.commons.validator.ValidatorAction defines
non-transient non-serializable instance field validationMethodBAD_PRACTICE
SE_BAD_FIELD<http://findbugs.sourceforge.net/bugDescriptions.html#SE_BAD_FIELD>Not
availableHigh
Gary

On Sun, Jan 29, 2012 at 8:59 AM, Simone Tripodi <simonetripodi@apache.org>wrote:

> Hi all again mates :)
>
> after the failing RC1, I open the VOTE for Apache Commons validator
> 1.4.0 based on RC2. Follow details:
>
> Tag:
>
>
> https://svn.apache.org/repos/asf/commons/proper/validator/tags/VALIDATOR_1_4_0_RC2/
>
> Release notes:
>
>
> http://people.apache.org/builds/commons/validator/1.4.0/RC2/RELEASE-NOTES.txt
>
> Site:
>
>    http://people.apache.org/builds/commons/validator/1.4.0/RC2/site/
> (broken links in the sidebar will be fixed once the site will be
> redeployed)
>
> Binaries:
>
>    http://people.apache.org/builds/commons/validator/1.4.0/RC2/binaries/
>
> Maven Artifacts
>
>    https://repository.apache.org/content/repositories/orgapachecommons-153
>
> [ ] +1 release it
> [ ] +0 go ahead I don't care
> [ ] -0 not blocking, but...
> [ ] -1 no, do not release it because...
>
> Many thanks in advance for reviewing, all the best and have a nice day!
> -Simo
>
> http://people.apache.org/~simonetripodi/
> http://simonetripodi.livejournal.com/
> http://twitter.com/simonetripodi
> http://www.99soft.org/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>


-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message