commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benedikt Ritter <b...@systemoutprintln.de>
Subject Re: [jira] [Resolved] (SANDBOX-363) Check if value is of the correct type in Argument.argument( Class<T> type, V value )
Date Sun, 22 Jan 2012 22:31:49 GMT
Am 22.01.2012 22:32, schrieb Simone Tripodi (Resolved) (JIRA):
>
>       [ https://issues.apache.org/jira/browse/SANDBOX-363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
>
> Simone Tripodi resolved SANDBOX-363.
> ------------------------------------
>
>      Resolution: Fixed
>        Assignee: Simone Tripodi
>
> patch applied, see [r1234616|https://svn.apache.org/viewvc?view=revision&revision=1234616]
>
> as a side note: {{Argument.getParameterTypes}} is an internal method, I moved the checks
in the higher level, as soon as arguments need to be checked, because invoked in constructors
or methods.

getParameterTypes has default visibility and for that reason can be used 
by other classes (for example BeanAccessor ;-). So I wouldn't exactly 
call it an internal method. Wouldn't it be better to leave the check in 
there?

>
> Thanks for contributing! ;)
>
>> Check if value is of the correct type in Argument.argument( Class<T>  type,
V value )
>> ------------------------------------------------------------------------------------
>>
>>                  Key: SANDBOX-363
>>                  URL: https://issues.apache.org/jira/browse/SANDBOX-363
>>              Project: Commons Sandbox
>>           Issue Type: Improvement
>>           Components: BeanUtils2
>>     Affects Versions: Nightly Builds
>>             Reporter: Benedikt Ritter
>>             Assignee: Simone Tripodi
>>             Priority: Minor
>>          Attachments: SANDBOX-363.txt, SANDBOX-363v2.txt
>>
>>
>> Although the compiler should check that value is always of the correct type, a programmatic
check should back this up.
>
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message