Return-Path: X-Original-To: apmail-commons-dev-archive@www.apache.org Delivered-To: apmail-commons-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CF9907C07 for ; Mon, 5 Dec 2011 22:25:45 +0000 (UTC) Received: (qmail 8567 invoked by uid 500); 5 Dec 2011 22:25:45 -0000 Delivered-To: apmail-commons-dev-archive@commons.apache.org Received: (qmail 8484 invoked by uid 500); 5 Dec 2011 22:25:45 -0000 Mailing-List: contact dev-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Commons Developers List" Delivered-To: mailing list dev@commons.apache.org Received: (qmail 8470 invoked by uid 99); 5 Dec 2011 22:25:45 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 05 Dec 2011 22:25:45 +0000 X-ASF-Spam-Status: No, hits=-2.3 required=5.0 tests=FREEMAIL_FROM,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of jak-commons-dev@m.gmane.org designates 80.91.229.12 as permitted sender) Received: from [80.91.229.12] (HELO lo.gmane.org) (80.91.229.12) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 05 Dec 2011 22:25:37 +0000 Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1RXgyF-0007Ts-RM for dev@commons.apache.org; Mon, 05 Dec 2011 23:25:11 +0100 Received: from hsi-kbw-046-005-049-185.hsi8.kabel-badenwuerttemberg.de ([46.5.49.185]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 05 Dec 2011 23:25:11 +0100 Received: from joerg.schaible by hsi-kbw-046-005-049-185.hsi8.kabel-badenwuerttemberg.de with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 05 Dec 2011 23:25:11 +0100 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: dev@commons.apache.org To: dev@commons.apache.org From: =?UTF-8?B?SsO2cmc=?= Schaible Subject: Re: [JEXL] [PreVOTE] OK to release Jexl with some Clirr errors but no package/id change? Followup-To: gmane.comp.jakarta.commons.devel Date: Mon, 05 Dec 2011 23:21:42 +0100 Lines: 74 Message-ID: References: Reply-To: joerg.schaible@gmx.de Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7Bit X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: hsi-kbw-046-005-049-185.hsi8.kabel-badenwuerttemberg.de Mail-Copies-To: nobody User-Agent: KNode/4.4.11 Go for 2.1. The problem of binary incompatibility only arise if you do *not* have access to the sources. sebb wrote: > The Jexl 2.0 branch now has only a few incompatibilities reported by > Clirr (see below). > > Also the 2.0.1 JUnit tests now run (with minor essential changes) > against both 2.0.1 and 2.1-SNAPSHOT. > > The remaining errors all relate to adding methods to interfaces. > According to the JLS [1], adding methods to an interface does not > break *binary* compatibility; however of course it will break source > compatibility. > I assume that Clirr has got this wrong; or is failing to distinguish > source compatibility from binary compatibility. > There is a test case to show this - > ScriptTest.testScriptInterfaceBinaryCompat() - in the > COMMONS_JEXL_2_0_1_TEST branch. > > I think it would be OK to release the code without changing package > names / Maven id if other Commons developers agree. > What do others think? > > Assuming that there are no objections, there is the question of what > version to use. > > The changes clearly require at least a minor version bump, i.e. 2.1 > rather than 2.0.2. > It is unlikely that any users will have implemented the Script > interface directly; any that have done so will need to update their > source before recompiling. > Does such a source incompatibility require a major version bump to 3.0? > [Note: this does *not* mean a package change is required; however a > package change would require a major version bump] > > I think this discussion is best held separately from any release vote, > as there are always plenty of other items to check in a release > vote... > > ===== > > ERROR: 7012: org.apache.commons.jexl2.introspection.Uberspect: Method > 'public org.apache.commons.jexl2.introspection.JexlMethod > getConstructorMethod(java.lang.Object, java.lang.Object[], > org.apache.commons.jexl2.JexlInfo)' has been added to an interface > ERROR: 7012: org.apache.commons.jexl2.JexlInfo: Method 'public > org.apache.commons.jexl2.DebugInfo debugInfo()' has been added to an > interface > ERROR: 7012: org.apache.commons.jexl2.Script: Method 'public > java.lang.Object execute(org.apache.commons.jexl2.JexlContext, > java.lang.Object[])' has been added to an interface > ERROR: 7012: org.apache.commons.jexl2.Script: Method 'public > java.lang.String[] getLocalVariables()' has been added to an interface > ERROR: 7012: org.apache.commons.jexl2.Script: Method 'public > java.lang.String[] getParameters()' has been added to an interface > ERROR: 7012: org.apache.commons.jexl2.Script: Method 'public > java.util.concurrent.Callable > callable(org.apache.commons.jexl2.JexlContext)' has been added to an > interface > ERROR: 7012: org.apache.commons.jexl2.Script: Method 'public > java.util.concurrent.Callable > callable(org.apache.commons.jexl2.JexlContext, java.lang.Object[])' > has been added to an interface > ERROR: 7012: org.apache.commons.jexl2.Script: Method 'public > java.util.Set getVariables()' has been added to an interface > > [1] > [http://java.sun.com/docs/books/jls/second_edition/html/binaryComp.doc.html#45347 --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org For additional commands, e-mail: dev-help@commons.apache.org