commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: svn commit: r1214691 - in /commons/proper/cli/trunk/src/main/java/org/apache/commons/cli: HelpFormatter.java Parser.java
Date Thu, 15 Dec 2011 11:05:19 GMT
On 15 December 2011 10:56, Emmanuel Bourg <ebourg@apache.org> wrote:
> Le 15/12/2011 11:36, sebb a écrit :
>
>
>>> Removed unnecessary final modifiers
>>
>>
>> Why?
>
>
> As stated, because these method parameters don't need to be final.
>
>
>
>> final should always be used where possible on fields.
>>
>> Both to document that the field is not intended to be entirely
>> replaced, and also to help with safe data publication across threads.
>
>
> This is a local variable, not a field.

Ah, OK then.

> Also keep in mind that CLI is generally not used in a multi thread context,
> the command line is only parsed by the main application thread.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message