commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gary Gregory <garydgreg...@gmail.com>
Subject Re: [Sanselan] Lots of throws clauses that don't actually apply
Date Tue, 20 Dec 2011 17:25:04 GMT
+1 to cleaning it up.

Do you want to set the POM to Java 5 while you're in there? The code
does not compile on Java 1.4.

This would then be an opportunity to upgrade the plugins and add
FindBugs, Checkstyle, and PMD reports.

Gary

On Tue, Dec 20, 2011 at 12:16 PM, sebb <sebbaz@gmail.com> wrote:
> There are lots of throws clauses on methods that don't actually throw them.
>
> These mainly relate to ImageReadException and ImageWriteException
>
> In the case of an abstract class, or a class that's designed for
> sub-classing, that may be OK, but the throws clauses should then be
> documented to avoid compiler warnings.
>
> Otherwise, the clauses should probably be removed - agreed?
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>



-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
JUnit in Action, 2nd Ed: http://bit.ly/ECvg0
Spring Batch in Action: http://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message