commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gary Gregory <garydgreg...@gmail.com>
Subject Re: [pool] [POOL-208] Support Java 1.5 Generics in version 1.x.
Date Wed, 21 Dec 2011 16:35:01 GMT
On Wed, Dec 21, 2011 at 11:22 AM, Phil Steitz <phil.steitz@gmail.com> wrote:

> On 12/21/11 9:14 AM, Gary Gregory wrote:
> > I created branches/1_5_RELEASE from trunk before the POOL-208 commits.
> > I expect 1.5.x fixes to be ported there from POOL_1_X.
>
> Please have a look at the actual code bases here.  Trunk is
> generified, 2.0 code.  What I need restored is the old 1_5_X branch
> to be able to patch 1.5.x.
>

Sorry about that, I fixed branches/1_5_RELEASE to contain 1.5.8-SNAPSHOT.

Gary


> Does anyone know svn commands that will allow me to create a branch
> including the 1_5_X code before the commit that overwrote that branch?
>
> Phil
> >  If not I'll
> > watch for 1.5.x releases and port to 1.6.
> >
> > Gary
> >
> > On Dec 21, 2011, at 11:03, Phil Steitz <phil.steitz@gmail.com> wrote:
> >
> >> On 12/21/11 6:13 AM, Gary Gregory wrote:
> >>> Hello Generics fan,
> >>>
> >>> Please review and continue on [POOL-208] Support Java 1.5 Generics in
> >>> version 1.x.
> >>>
> >>> The code is in the POOL_1_X branch, cooking up for a 1.6 release very
> soon.
> >> We need to sort out the branch structure here.  I had prepared the
> >> 1_X branch for 1.5.8.  Did you take a copy of that branch and move
> >> it somewhere?  The website was published from that branch.  Please
> >> fix this.
> >>
> >> Phil
> >>> There are NO code changes in the main code that should affect behavior.
> >>> I've only touched code for adding generics.
> >>>
> >>> As we all know, this is binary compatible with 1.5.x because of type
> >>> erasure.
> >>>
> >>> I have changed some of the tests because 100% source compatibility is
> not
> >>> possible.
> >>>
> >>> APIs that I could not fully generify are:
> >>>
> >>> - org.apache.commons.pool.PoolUtils.adapt(KeyedObjectPool<Object, V>,
> >>> Object)
> >>> -
> >>>
> org.apache.commons.pool.PoolUtils.adapt(KeyedPoolableObjectFactory<Object,
> >>> V>)
> >>>
> >>> Please dig in and help to make Pool1 with generics the best it can be
> for
> >>> 1.6.
> >>>
> >>> My goal is to ONLY change code for Generics.
> >>>
> >>> Other kind of fiddling like enhanced for-loops will make it harder to
> port
> >>> fixes to and from 1.5.x.
> >>>
> >>> If you like enhanced for-loops or other Java 5 features, I won't stop
> you,
> >>> but it is not my goal here.
> >>>
> >>> Thank you,
> >>> Gary
> >>>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> >> For additional commands, e-mail: dev-help@commons.apache.org
> >>
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>


-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message