commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Simone Tripodi <simonetrip...@apache.org>
Subject Re: [pool] [POOL-208] Support Java 1.5 Generics in version 1.x.
Date Fri, 23 Dec 2011 10:59:38 GMT
Hi again Gary!

I had another review after your latest commits, I just fixed 1 missing
@param comment, and IMHO in therms of having generics-only, this
release should be ready...

Do you have any plan? Thanks for driving this!
-Simo

http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/



On Wed, Dec 21, 2011 at 2:13 PM, Gary Gregory <garydgregory@gmail.com> wrote:
> Hello Generics fan,
>
> Please review and continue on [POOL-208] Support Java 1.5 Generics in
> version 1.x.
>
> The code is in the POOL_1_X branch, cooking up for a 1.6 release very soon.
>
> There are NO code changes in the main code that should affect behavior.
> I've only touched code for adding generics.
>
> As we all know, this is binary compatible with 1.5.x because of type
> erasure.
>
> I have changed some of the tests because 100% source compatibility is not
> possible.
>
> APIs that I could not fully generify are:
>
> - org.apache.commons.pool.PoolUtils.adapt(KeyedObjectPool<Object, V>,
> Object)
> -
> org.apache.commons.pool.PoolUtils.adapt(KeyedPoolableObjectFactory<Object,
> V>)
>
> Please dig in and help to make Pool1 with generics the best it can be for
> 1.6.
>
> My goal is to ONLY change code for Generics.
>
> Other kind of fiddling like enhanced for-loops will make it harder to port
> fixes to and from 1.5.x.
>
> If you like enhanced for-loops or other Java 5 features, I won't stop you,
> but it is not my goal here.
>
> Thank you,
> Gary
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
> Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message