commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Emmanuel Bourg <>
Subject Re: svn commit: r1214691 - in /commons/proper/cli/trunk/src/main/java/org/apache/commons/cli:
Date Thu, 15 Dec 2011 10:56:18 GMT
Le 15/12/2011 11:36, sebb a écrit :

>> Removed unnecessary final modifiers
> Why?

As stated, because these method parameters don't need to be final.

> final should always be used where possible on fields.
> Both to document that the field is not intended to be entirely
> replaced, and also to help with safe data publication across threads.

This is a local variable, not a field.

Also keep in mind that CLI is generally not used in a multi thread 
context, the command line is only parsed by the main application thread.

Emmanuel Bourg

View raw message