commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject Re: svn commit: r1213845 - in /commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl: GenericKeyedObjectPoolFactory.java GenericObjectPoolFactory.java
Date Tue, 13 Dec 2011 19:32:08 GMT
On 13/12/2011 18:40, sebb@apache.org wrote:
> Author: sebb
> Date: Tue Dec 13 18:40:48 2011
> New Revision: 1213845
> 
> URL: http://svn.apache.org/viewvc?rev=1213845&view=rev
> Log:
> Make factories thread-safe.
> [No existing tests actually used the setter methods which have now been removed]

This commit removes functionality and doesn't achieve the stated
objective since the config object is accessible and not thread-safe.

I am close to vetoing this commit.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message